Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] FastBoot compatibility #819
Conversation
sivakumar-kailasam
changed the title
Index page is now FastBoot compatible
[WIP] : Index page is now FastBoot compatible
Jun 27, 2017
sivakumar-kailasam
changed the title
[WIP] : Index page is now FastBoot compatible
WIP | FastBoot compatibility
Jun 27, 2017
sivakumar-kailasam
changed the title
WIP | FastBoot compatibility
[WIP] FastBoot compatibility
Jun 27, 2017
sivakumar-kailasam
and others
added some commits
Jun 27, 2017
Turbo87
reviewed
Jun 28, 2017
app/controllers/application.js
Outdated
| this.setProperties({ | ||
| 'flashError': this.get('nextFlashError'), | ||
| 'nextFlashError': null | ||
| }); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sivakumar-kailasam
Jun 29, 2017
Author
Contributor
Not related. I just grouped couple of individual set calls. Should've probably kept in a different commit.
Turbo87
reviewed
Jun 28, 2017
| url = `${protocol}://${host}`; | ||
| } | ||
| return url; | ||
| }), |
This comment has been minimized.
This comment has been minimized.
app/routes/logout.js
Outdated
| activate() { | ||
| Ember.$.getJSON('/logout', () => { | ||
| fetch(`${this.get('appURL')}/logout`, () => { |
This comment has been minimized.
This comment has been minimized.
config/environment.js
Outdated
| }, | ||
|
|
||
| fastboot: { | ||
| hostWhitelist: ['crates.io', /^localhost:\d+$/] |
This comment has been minimized.
This comment has been minimized.
locks
and others
added some commits
Jun 28, 2017
Turbo87
reviewed
Jun 29, 2017
app/mixins/fastboot-utils.js
Outdated
| * during Server Side Rendering(SSR) via FastBoot, | ||
| * the JS Fetch API doesn't work with absolute urls. | ||
| * This property gives the URL prefix for those network calls. | ||
| * */ |
This comment has been minimized.
This comment has been minimized.
Turbo87
Jun 29, 2017
Member
isn't it the other way around? it doesn't work with relative URLs, right?
This comment has been minimized.
This comment has been minimized.
sivakumar-kailasam
Jun 29, 2017
Author
Contributor
danngit, you're right. I don't think we need it anymore if I use ajax service.
sivakumar-kailasam
added some commits
Jun 29, 2017
Turbo87
reviewed
Jun 29, 2017
app/controllers/me/index.js
Outdated
| @@ -1,20 +1,20 @@ | |||
| import Ember from 'ember'; | |||
| import ajax from 'ic-ajax'; | |||
|
|
|||
| const { inject: { service } } = Ember; | |||
This comment has been minimized.
This comment has been minimized.
Turbo87
Jun 29, 2017
Member
this will make it harder for the new modules codemod to transform it into an import from @ember/service... I'd rather just keep using the globals for now.
This comment has been minimized.
This comment has been minimized.
sivakumar-kailasam
Jun 29, 2017
Author
Contributor
Oh so that's why you've used full form everywhere. Got it!
This comment has been minimized.
This comment has been minimized.
sivakumar-kailasam
force-pushed the
sivakumar-kailasam:das-fastboot
branch
from
e158061
to
ffbfcbe
Jun 29, 2017
sivakumar-kailasam
added some commits
Jun 29, 2017
carols10cents
added
the
S-waiting-on-author
label
Jul 1, 2017
sivakumar-kailasam
added some commits
Jul 2, 2017
This comment has been minimized.
This comment has been minimized.
|
Closing this PR in favor of smaller PRs to get this repo to be fastboot compatible and then land one PR with the fastboot specific changes. |
sivakumar-kailasam
closed this
Sep 25, 2017
Turbo87
removed
the
S-waiting-on-author
label
Dec 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sivakumar-kailasam commentedJun 27, 2017
•
edited
Pages: