From e2298582ffc59578b1b70845b7b3479f29fe420a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 4 Oct 2024 07:11:57 +0000 Subject: [PATCH 1/2] Update dependency eslint-plugin-unicorn to v56 --- package.json | 2 +- pnpm-lock.yaml | 99 +++++++++++++++++++++----------------------------- 2 files changed, 42 insertions(+), 59 deletions(-) diff --git a/package.json b/package.json index 97e94410d29..9a63b5ce100 100644 --- a/package.json +++ b/package.json @@ -123,7 +123,7 @@ "eslint-plugin-prettier": "5.2.1", "eslint-plugin-qunit": "8.1.2", "eslint-plugin-qunit-dom": "0.2.0", - "eslint-plugin-unicorn": "55.0.0", + "eslint-plugin-unicorn": "56.0.0", "globby": "14.0.2", "loader.js": "4.7.0", "match-json": "1.3.7", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 0982d59cf18..1fc14bc2445 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -156,7 +156,7 @@ importers: version: 2.1.0 ember-cli-mirage: specifier: 3.0.4 - version: 3.0.4(hlgcyoz7zd4srhpnpq5r4trhz4) + version: 3.0.4(@ember-data/model@4.12.8)(@ember/test-helpers@4.0.4(@babel/core@7.25.7)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(ember-data@4.12.8(@babel/core@7.25.7)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(webpack@5.95.0))(ember-qunit@8.1.0(@ember/test-helpers@4.0.4(@babel/core@7.25.7)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(qunit@2.22.0))(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(miragejs@0.1.48)(webpack@5.95.0) ember-cli-notifications: specifier: 9.0.0 version: 9.0.0 @@ -260,8 +260,8 @@ importers: specifier: 0.2.0 version: 0.2.0(eslint@9.11.1) eslint-plugin-unicorn: - specifier: 55.0.0 - version: 55.0.0(eslint@9.11.1) + specifier: 56.0.0 + version: 56.0.0(eslint@9.11.1) globby: specifier: 14.0.2 version: 14.0.2 @@ -4615,8 +4615,8 @@ packages: resolution: {integrity: sha512-2gDQdHlQW8GVXD7YYkO8vbm9Ldc60JeGMuQN5QlD48OeZ8znBvvoHWZZMeXjvoDPReGaLEvyuWrDtrI8bDbcqw==} engines: {node: ^16.0.0 || ^18.0.0 || >=20.0.0} - eslint-plugin-unicorn@55.0.0: - resolution: {integrity: sha512-n3AKiVpY2/uDcGrS3+QsYDkjPfaOrNrsfQxU9nt5nitd9KuvVXrfAvgCO9DYPSfap+Gqjw9EOrXIsBp5tlHZjA==} + eslint-plugin-unicorn@56.0.0: + resolution: {integrity: sha512-aXpddVz/PQMmd69uxO98PA4iidiVNvA0xOtbpUoz1WhBd4RxOQQYqN618v68drY0hmy5uU2jy1bheKEVWBjlPw==} engines: {node: '>=18.18'} peerDependencies: eslint: '>=8.56.0' @@ -8939,7 +8939,7 @@ snapshots: '@babel/core': 7.25.7(supports-color@8.1.1) '@babel/helper-module-imports': 7.24.7(supports-color@8.1.1) '@babel/helper-simple-access': 7.24.7(supports-color@8.1.1) - '@babel/helper-validator-identifier': 7.24.7 + '@babel/helper-validator-identifier': 7.25.7 '@babel/traverse': 7.25.6(supports-color@8.1.1) transitivePeerDependencies: - supports-color @@ -9048,7 +9048,7 @@ snapshots: '@babel/highlight@7.24.7': dependencies: - '@babel/helper-validator-identifier': 7.24.7 + '@babel/helper-validator-identifier': 7.25.7 chalk: 2.4.2 js-tokens: 4.0.0 picocolors: 1.1.0 @@ -9420,7 +9420,7 @@ snapshots: '@babel/core': 7.25.7(supports-color@8.1.1) '@babel/helper-module-transforms': 7.25.2(@babel/core@7.25.7)(supports-color@8.1.1) '@babel/helper-plugin-utils': 7.24.8 - '@babel/helper-validator-identifier': 7.24.7 + '@babel/helper-validator-identifier': 7.25.7 '@babel/traverse': 7.25.6(supports-color@8.1.1) transitivePeerDependencies: - supports-color @@ -10033,7 +10033,7 @@ snapshots: dependencies: postcss: 8.4.47 - '@ember-data/adapter@4.12.8(@ember-data/store@4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7))': + '@ember-data/adapter@4.12.8(@ember-data/store@4.12.8)(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7))': dependencies: '@ember-data/private-build-infra': 4.12.8 '@ember-data/store': 4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)) @@ -10164,7 +10164,7 @@ snapshots: '@ember-data/rfc395-data@0.0.4': {} - '@ember-data/serializer@4.12.8(@ember-data/store@4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7))': + '@ember-data/serializer@4.12.8(@ember-data/store@4.12.8)(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7))': dependencies: '@ember-data/private-build-infra': 4.12.8 '@ember-data/store': 4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)) @@ -11146,17 +11146,17 @@ snapshots: '@types/ember@4.0.11': dependencies: '@types/ember__application': 4.0.11(@babel/core@7.25.7) - '@types/ember__array': 4.0.10(@babel/core@7.25.7) - '@types/ember__component': 4.0.22(@babel/core@7.25.7) - '@types/ember__controller': 4.0.12 - '@types/ember__debug': 4.0.8 - '@types/ember__engine': 4.0.11 + '@types/ember__array': 4.0.10 + '@types/ember__component': 4.0.22 + '@types/ember__controller': 4.0.12(@babel/core@7.25.7) + '@types/ember__debug': 4.0.8(@babel/core@7.25.7) + '@types/ember__engine': 4.0.11(@babel/core@7.25.7) '@types/ember__error': 4.0.6 - '@types/ember__object': 4.0.12 + '@types/ember__object': 4.0.12(@babel/core@7.25.7) '@types/ember__polyfills': 4.0.6 '@types/ember__routing': 4.0.22 - '@types/ember__runloop': 4.0.10 - '@types/ember__service': 4.0.9 + '@types/ember__runloop': 4.0.10(@babel/core@7.25.7) + '@types/ember__service': 4.0.9(@babel/core@7.25.7) '@types/ember__string': 3.0.15 '@types/ember__template': 4.0.7 '@types/ember__test': 4.0.6(@babel/core@7.25.7) @@ -11196,8 +11196,8 @@ snapshots: dependencies: '@glimmer/component': 1.1.2(@babel/core@7.25.7) '@types/ember': 4.0.11 - '@types/ember__engine': 4.0.11 - '@types/ember__object': 4.0.12 + '@types/ember__engine': 4.0.11(@babel/core@7.25.7) + '@types/ember__object': 4.0.12(@babel/core@7.25.7) '@types/ember__owner': 4.0.9 '@types/ember__routing': 4.0.22 transitivePeerDependencies: @@ -11208,6 +11208,11 @@ snapshots: dependencies: '@types/ember__object': 3.12.13 + '@types/ember__array@4.0.10': + dependencies: + '@types/ember': 4.0.11 + '@types/ember__object': 4.0.12(@babel/core@7.25.7) + '@types/ember__array@4.0.10(@babel/core@7.25.7)': dependencies: '@types/ember': 4.0.11(@babel/core@7.25.7) @@ -11221,6 +11226,11 @@ snapshots: '@types/ember__object': 3.12.13 '@types/jquery': 3.5.31 + '@types/ember__component@4.0.22': + dependencies: + '@types/ember': 4.0.11 + '@types/ember__object': 4.0.12(@babel/core@7.25.7) + '@types/ember__component@4.0.22(@babel/core@7.25.7)': dependencies: '@types/ember': 4.0.11(@babel/core@7.25.7) @@ -11233,10 +11243,6 @@ snapshots: dependencies: '@types/ember__object': 3.12.13 - '@types/ember__controller@4.0.12': - dependencies: - '@types/ember__object': 4.0.12 - '@types/ember__controller@4.0.12(@babel/core@7.25.7)': dependencies: '@types/ember__object': 4.0.12(@babel/core@7.25.7) @@ -11249,11 +11255,6 @@ snapshots: '@types/ember__engine': 3.16.9 '@types/ember__object': 3.12.13 - '@types/ember__debug@4.0.8': - dependencies: - '@types/ember__object': 4.0.12 - '@types/ember__owner': 4.0.9 - '@types/ember__debug@4.0.8(@babel/core@7.25.7)': dependencies: '@types/ember__object': 4.0.12(@babel/core@7.25.7) @@ -11266,11 +11267,6 @@ snapshots: dependencies: '@types/ember__object': 3.12.13 - '@types/ember__engine@4.0.11': - dependencies: - '@types/ember__object': 4.0.12 - '@types/ember__owner': 4.0.9 - '@types/ember__engine@4.0.11(@babel/core@7.25.7)': dependencies: '@types/ember__object': 4.0.12(@babel/core@7.25.7) @@ -11287,11 +11283,6 @@ snapshots: dependencies: '@types/rsvp': 4.0.9 - '@types/ember__object@4.0.12': - dependencies: - '@types/ember': 4.0.11 - '@types/rsvp': 4.0.9 - '@types/ember__object@4.0.12(@babel/core@7.25.7)': dependencies: '@types/ember': 4.0.11(@babel/core@7.25.7) @@ -11316,26 +11307,22 @@ snapshots: '@types/ember__routing@4.0.22': dependencies: '@types/ember': 4.0.11 - '@types/ember__controller': 4.0.12 - '@types/ember__object': 4.0.12 - '@types/ember__service': 4.0.9 + '@types/ember__controller': 4.0.12(@babel/core@7.25.7) + '@types/ember__object': 4.0.12(@babel/core@7.25.7) + '@types/ember__service': 4.0.9(@babel/core@7.25.7) '@types/ember__routing@4.0.22(@babel/core@7.25.7)': dependencies: '@types/ember': 4.0.11(@babel/core@7.25.7) - '@types/ember__controller': 4.0.12 + '@types/ember__controller': 4.0.12(@babel/core@7.25.7) '@types/ember__object': 4.0.12(@babel/core@7.25.7) - '@types/ember__service': 4.0.9 + '@types/ember__service': 4.0.9(@babel/core@7.25.7) transitivePeerDependencies: - '@babel/core' - supports-color '@types/ember__runloop@3.16.10': {} - '@types/ember__runloop@4.0.10': - dependencies: - '@types/ember': 4.0.11 - '@types/ember__runloop@4.0.10(@babel/core@7.25.7)': dependencies: '@types/ember': 4.0.11(@babel/core@7.25.7) @@ -11347,10 +11334,6 @@ snapshots: dependencies: '@types/ember__object': 3.12.13 - '@types/ember__service@4.0.9': - dependencies: - '@types/ember__object': 4.0.12 - '@types/ember__service@4.0.9(@babel/core@7.25.7)': dependencies: '@types/ember__object': 4.0.12(@babel/core@7.25.7) @@ -14169,7 +14152,7 @@ snapshots: ember-cli-lodash-subset@2.0.1: {} - ember-cli-mirage@3.0.4(hlgcyoz7zd4srhpnpq5r4trhz4): + ember-cli-mirage@3.0.4(@ember-data/model@4.12.8)(@ember/test-helpers@4.0.4(@babel/core@7.25.7)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(ember-data@4.12.8(@babel/core@7.25.7)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(webpack@5.95.0))(ember-qunit@8.1.0(@ember/test-helpers@4.0.4(@babel/core@7.25.7)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(qunit@2.22.0))(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(miragejs@0.1.48)(webpack@5.95.0): dependencies: '@babel/core': 7.25.7(supports-color@8.1.1) '@embroider/macros': 1.16.6 @@ -14501,7 +14484,7 @@ snapshots: ember-data@4.12.8(@babel/core@7.25.7)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0))(webpack@5.95.0): dependencies: - '@ember-data/adapter': 4.12.8(@ember-data/store@4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7)) + '@ember-data/adapter': 4.12.8(@ember-data/store@4.12.8)(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7)) '@ember-data/debug': 4.12.8(@ember-data/store@4.12.8)(@ember/string@3.1.1)(webpack@5.95.0) '@ember-data/graph': 4.12.8(@ember-data/store@4.12.8) '@ember-data/json-api': 4.12.8(@ember-data/graph@4.12.8)(@ember-data/store@4.12.8) @@ -14509,7 +14492,7 @@ snapshots: '@ember-data/model': 4.12.8(@babel/core@7.25.7)(@ember-data/debug@4.12.8)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/store@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7))(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)) '@ember-data/private-build-infra': 4.12.8 '@ember-data/request': 4.12.8 - '@ember-data/serializer': 4.12.8(@ember-data/store@4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)))(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7)) + '@ember-data/serializer': 4.12.8(@ember-data/store@4.12.8)(@ember/string@3.1.1)(ember-inflector@5.0.1(@babel/core@7.25.7)) '@ember-data/store': 4.12.8(@babel/core@7.25.7)(@ember-data/graph@4.12.8)(@ember-data/json-api@4.12.8)(@ember-data/legacy-compat@4.12.8)(@ember-data/model@4.12.8)(@ember-data/tracking@4.12.8)(@ember/string@3.1.1)(@glimmer/tracking@1.1.2)(ember-source@5.12.0(@glimmer/component@1.1.2(@babel/core@7.25.7))(rsvp@4.8.5)(webpack@5.95.0)) '@ember-data/tracking': 4.12.8 '@ember/edition-utils': 1.2.0 @@ -15139,9 +15122,9 @@ snapshots: transitivePeerDependencies: - eslint - eslint-plugin-unicorn@55.0.0(eslint@9.11.1): + eslint-plugin-unicorn@56.0.0(eslint@9.11.1): dependencies: - '@babel/helper-validator-identifier': 7.24.7 + '@babel/helper-validator-identifier': 7.25.7 '@eslint-community/eslint-utils': 4.4.0(eslint@9.11.1) ci-info: 4.0.0 clean-regexp: 1.0.0 @@ -17705,7 +17688,7 @@ snapshots: parse-json@5.2.0: dependencies: - '@babel/code-frame': 7.24.7 + '@babel/code-frame': 7.25.7 error-ex: 1.3.2 json-parse-even-better-errors: 2.3.1 lines-and-columns: 1.2.4 From 6d84f7b0ccc89a7cb996560e1e2a0700af682a84 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Fri, 4 Oct 2024 09:17:21 +0200 Subject: [PATCH 2/2] eslint-plugin-unicorn: Disable new rules --- .eslintrc.js | 2 ++ app/initializers/hashchange.js | 1 + 2 files changed, 3 insertions(+) diff --git a/.eslintrc.js b/.eslintrc.js index cf5920c1706..a0b787261f5 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -56,6 +56,8 @@ module.exports = { 'unicorn/no-nested-ternary': 'off', // disabled because of unfixable false positives 'unicorn/prevent-abbreviations': 'off', + // disabled because we are targeting only browsers at the moment + 'unicorn/prefer-global-this': 'off', // disabled because we don't want to go all-in on ES6 modules for Node.js code yet 'unicorn/prefer-module': 'off', // disabled because it seems unnecessary diff --git a/app/initializers/hashchange.js b/app/initializers/hashchange.js index d59f6946fd8..9ced904910f 100644 --- a/app/initializers/hashchange.js +++ b/app/initializers/hashchange.js @@ -12,6 +12,7 @@ function findElementByFragmentName(document, name) { } try { + // eslint-disable-next-line unicorn/prefer-query-selector return document.querySelector(`#${name}`) || document.getElementsByName(name)[0]; } catch { // Catches exceptions thrown when an anchor in a readme was invalid (see issue #3108)