From db4c1029c5ba9ca77b4364bc6c012717d6d693c3 Mon Sep 17 00:00:00 2001
From: Tobias Bieniek <tobias@bieniek.cloud>
Date: Sun, 13 Oct 2024 01:15:07 +0200
Subject: [PATCH] tests/models/krate: Replace `TestApp` usage with
 `TestDatabase`

We don't need to spin up a full-blown app for this test, when all we need is a simple database connection.
---
 src/tests/models/krate.rs | 91 ++++++++++++++++++++++-----------------
 1 file changed, 51 insertions(+), 40 deletions(-)

diff --git a/src/tests/models/krate.rs b/src/tests/models/krate.rs
index f4967076581..9328fa486f0 100644
--- a/src/tests/models/krate.rs
+++ b/src/tests/models/krate.rs
@@ -1,47 +1,58 @@
+use crate::schema::users;
 use crate::tests::builders::{CrateBuilder, VersionBuilder};
 use crate::tests::util::insta::assert_json_snapshot;
-use crate::tests::TestApp;
 use chrono::{Days, Utc};
+use crates_io_test_db::TestDatabase;
+use diesel::{ExpressionMethods, RunQueryDsl};
 
 #[test]
 fn index_metadata() {
-    let (app, _, user) = TestApp::init().with_user();
-    let user = user.as_model();
-
-    app.db(|conn| {
-        let created_at_1 = Utc::now()
-            .checked_sub_days(Days::new(14))
-            .unwrap()
-            .naive_utc();
-
-        let created_at_2 = Utc::now()
-            .checked_sub_days(Days::new(7))
-            .unwrap()
-            .naive_utc();
-
-        let fooo = CrateBuilder::new("foo", user.id)
-            .version(VersionBuilder::new("0.1.0"))
-            .expect_build(conn);
-
-        let metadata = fooo.index_metadata(conn).unwrap();
-        assert_json_snapshot!(metadata);
-
-        let bar = CrateBuilder::new("bar", user.id)
-            .version(
-                VersionBuilder::new("1.0.0-beta.1")
-                    .created_at(created_at_1)
-                    .yanked(true),
-            )
-            .version(VersionBuilder::new("1.0.0").created_at(created_at_1))
-            .version(
-                VersionBuilder::new("2.0.0")
-                    .created_at(created_at_2)
-                    .dependency(&fooo, None),
-            )
-            .version(VersionBuilder::new("1.0.1").checksum("0123456789abcdef"))
-            .expect_build(conn);
-
-        let metadata = bar.index_metadata(conn).unwrap();
-        assert_json_snapshot!(metadata);
-    });
+    let test_db = TestDatabase::new();
+    let mut conn = test_db.connect();
+
+    let user_id = diesel::insert_into(users::table)
+        .values((
+            users::name.eq("user1"),
+            users::gh_login.eq("user1"),
+            users::gh_id.eq(42),
+            users::gh_access_token.eq("some random token"),
+        ))
+        .returning(users::id)
+        .get_result::<i32>(&mut conn)
+        .unwrap();
+
+    let created_at_1 = Utc::now()
+        .checked_sub_days(Days::new(14))
+        .unwrap()
+        .naive_utc();
+
+    let created_at_2 = Utc::now()
+        .checked_sub_days(Days::new(7))
+        .unwrap()
+        .naive_utc();
+
+    let fooo = CrateBuilder::new("foo", user_id)
+        .version(VersionBuilder::new("0.1.0"))
+        .expect_build(&mut conn);
+
+    let metadata = fooo.index_metadata(&mut conn).unwrap();
+    assert_json_snapshot!(metadata);
+
+    let bar = CrateBuilder::new("bar", user_id)
+        .version(
+            VersionBuilder::new("1.0.0-beta.1")
+                .created_at(created_at_1)
+                .yanked(true),
+        )
+        .version(VersionBuilder::new("1.0.0").created_at(created_at_1))
+        .version(
+            VersionBuilder::new("2.0.0")
+                .created_at(created_at_2)
+                .dependency(&fooo, None),
+        )
+        .version(VersionBuilder::new("1.0.1").checksum("0123456789abcdef"))
+        .expect_build(&mut conn);
+
+    let metadata = bar.index_metadata(&mut conn).unwrap();
+    assert_json_snapshot!(metadata);
 }