fetch CrateDetails via MatchedRelease to save one SQL query per request #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
dont-fetch-releases-twice
branch
2 times, most recently
from
6743bc5 to
03c4977
Compare
GuillaumeGomez
approved these changes
Mar 1, 2024
Member
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Sounds pretty nice! Please wait for @Nemo157's review before merging.
Nemo157
reviewed
Mar 1, 2024
syphar
force-pushed
the
dont-fetch-releases-twice
branch
from
03c4977 to
63ac89a
Compare
Nemo157
approved these changes
Mar 1, 2024
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2383 I realized that we were fetching all releases for a crate twice, once in
match_version, once when fetchingCrateDetails.This is the fix, should make some endpoints a little faster: