Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Mar 10, 2024

I saw this while looking at other code in the web handlers.

  • We already fetch the list of all releases in match_version, so we don't need to do it again in the web handlers. Since fetch CrateDetails via MatchedRelease to save one SQL query per request #2435 we store the list on our matched release too.
  • we were also fetching too much information in the sql statements that we already have
  • secondly I saw places where crates.name was used in generating an inner path, while target_name is what we need here.

@syphar syphar requested a review from a team as a code owner March 10, 2024 04:11
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 10, 2024
@syphar syphar merged commit a82561c into rust-lang:master Mar 10, 2024
@syphar syphar deleted the ajax-speed branch March 10, 2024 08:28
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 10, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants