Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Dec 5, 2025

When trying to download bigger archives, I saw some errors:

curl: (92) HTTP/2 stream 1 was not closed cleanly: PROTOCOL_ERROR (err 1)

or

http: error: ChunkedEncodingError: ("Connection broken: InvalidChunkLength(got length b'\r\n', 0 bytes read)", InvalidChunkLength(got length b'\r\n', 0 bytes read))

After a little digging I saw that the connection between fastly & nginx is cut after streaming exactly 100 MiB,

which made me think about limits :)

Then :

For now I chose to just forbid caching when the file is too big, segmented caching would be a little more effort, with IMO limited short-term gain. These archives aren't downloaded that often.

@syphar syphar self-assigned this Dec 5, 2025
@syphar syphar requested a review from a team as a code owner December 5, 2025 12:24
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 5, 2025
@syphar syphar force-pushed the dont-cache-big-objects branch from b71f93c to c8109b8 Compare December 5, 2025 12:25
@marcoieni
Copy link
Member

looks good!

@syphar syphar force-pushed the dont-cache-big-objects branch from c8109b8 to 4db2505 Compare December 5, 2025 13:03
Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
@syphar syphar merged commit 5eed146 into rust-lang:main Dec 5, 2025
11 of 12 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 5, 2025
@syphar syphar deleted the dont-cache-big-objects branch December 5, 2025 13:17
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants