Build local packages#460
Merged
emilyalbini merged 4 commits intorust-lang:masterfrom Nov 4, 2019
Merged
Conversation
NOTE: this breaks backwards compatibility for build_package
Member
Author
|
Motivation: someone asked in the |
Member
Author
|
So after testing this locally I found that this crashes the web server once you try to actually load one of the local crates: The root cause is that local packages were never released, so they don't have a release time. The fix is to make |
Member
Author
|
Actually a better idea is to keep the time non-nullable and set the release time for local packages to the build time |
fixes crash when accessing built local documentation
Member
Author
|
This is ready for review. |
Member
|
This looks great! Thanks! |
This was referenced Dec 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this breaks backwards compatibility for
build_package. This could be avoided by adding a privatebuild_package_implfunction but that seems ugly :/ I'm open to suggestions on how to make this backwards compatible.