Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow trailing slash in standard-library redirects #476

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 15, 2019

fixes #474

@pietroalbini
Copy link
Member

I'd prefer not to duplicate the list of crates we redirect. A solution could be to create a static like this:

static DOC_RUST_LANG_ORG_REDIRECTS: &[&str] = &["alloc", "std", ...];

...and dynamically generate the routes?

@jyn514
Copy link
Member Author

jyn514 commented Nov 21, 2019

@pietroalbini I removed the duplicate code, want to take another look?

@pietroalbini
Copy link
Member

Looks great, thanks!

@pietroalbini pietroalbini merged commit 3fc0676 into rust-lang:master Nov 21, 2019
@jyn514 jyn514 deleted the trailing-slash branch November 21, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs.rs/std redirect works but not docs.rs/std/
2 participants