Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic viewing source if crate failed to build #519

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@jyn514
Copy link
Member

jyn514 commented Dec 12, 2019

Closes #517

Gives a 404 if you try to view the source instead of panicking

jyn514 added 2 commits Dec 12, 2019
closes #517

gives a 404 if you try to view the source
The webpage looks the same but it makes _me_ feel better at least
@jyn514

This comment has been minimized.

Copy link
Member Author

jyn514 commented Dec 12, 2019

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Dec 13, 2019

This looks great! There is still the problem that the "Source" tab is present even when we know it will lead to a 404, but I opened #520 to follow up with that.

@pietroalbini pietroalbini merged commit e0f7294 into rust-lang:master Dec 13, 2019
2 checks passed
2 checks passed
Test
Details
Docker
Details
@jyn514 jyn514 deleted the jyn514:panic-source branch Dec 13, 2019
pietroalbini added a commit that referenced this pull request Dec 13, 2019
This reverts commit e0f7294, reversing
changes made to 1de587d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.