Skip to content

Conversation

@Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Dec 5, 2025

Fix #515


Parts of this PR were drafted with assistance from Codex (with gpt-5.1-codex-max) and fully reviewed and edited by me. I take full responsibility for all changes.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo force-pushed the xuanwo/fix-ffi-ambiguous branch from a8fc383 to 2a6ca2a Compare December 5, 2025 06:38
not(feature = "zlib-rs"),
not(feature = "miniz_oxide")
))]
compile_error!("No compression backend selected; enable one of `zlib`, `zlib-ng`, `zlib-rs`, or the default `rust_backend` feature.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch added for better UE, I'm open to just remove it.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million!

Even though I can't tell that it will fix #515 just by looking at it, let's give it a shot anyway as it does look reasonable.

@Byron
Copy link
Member

Byron commented Dec 5, 2025

@Xuanwo I'd need you to bump Cargo.toml as well so I can create a release right away.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Dec 5, 2025

@Xuanwo I'd need you to bump Cargo.toml as well so I can create a release right away.

Great, will do.

DONE @Byron, let's go

Signed-off-by: Xuanwo <github@xuanwo.io>
@Byron Byron merged commit 69ff494 into rust-lang:main Dec 5, 2025
15 checks passed
@Xuanwo Xuanwo deleted the xuanwo/fix-ffi-ambiguous branch December 5, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unintentional breaking change: Deflate is ambiguous

2 participants