Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename oneshot:Sender::poll_cancel to poll_canceled #1908

Merged
merged 1 commit into from Oct 10, 2019

Conversation

seanmonstar
Copy link
Collaborator

@seanmonstar seanmonstar commented Oct 9, 2019

In most other places, poll_action means that 'action' is happening
asynchronously. The name poll_cancel implies that the call will cancel
the oneshot, but really we just wish to poll if it has been canceled.

In most other places, `poll_action` means that 'action' is happening
asynchronously. The name `poll_cancel` implies that the call will cancel
the oneshot, but really we just wish to poll if it *has been* canceled.
@cramertj
Copy link
Member

cramertj commented Oct 10, 2019

Makes sense to me, thanks!

@cramertj cramertj merged commit 3df6f46 into rust-lang:master Oct 10, 2019
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants