Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Relax bounds for FuturesUnordered #2085

Merged
merged 1 commit into from Feb 24, 2020
Merged

Conversation

@jonhoo
Copy link
Contributor

jonhoo commented Feb 21, 2020

There is no need for the FuturesUnordered constructors to require that
the provided Fut type implements Future. It needlessly requires
callers to also propagate that bound onto their constructors, all the
way up the chain. This patch removes the bounds except where necessary,
specifically for the impl Stream.

There is no need for the `FuturesUnordered` constructors to require that
the provided `Fut` type implements `Future`. It needlessly requires
callers to also propagate that bound onto their constructors, all the
way up the chain. This patch removes the bounds except where necessary,
specifically for the `impl Stream`.
@cramertj

This comment has been minimized.

Copy link
Member

cramertj commented Feb 24, 2020

Somewhat sad that this is the best way forward given the eventual plan for implied bounds, but I suppose it's the standard way of doing things for now.

@cramertj cramertj merged commit c858a2b into rust-lang:master Feb 24, 2020
1 check failed
1 check failed
Travis CI - Pull Request Build Failed
Details
@jonhoo jonhoo deleted the jonhoo:relax-new-bound branch Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.