Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit clear in ReadyToRunQueue::drop #2493

Merged
merged 2 commits into from Sep 2, 2021

Conversation

ibraheemdev
Copy link
Contributor

Resolves #2473

@taiki-e
Copy link
Member

taiki-e commented Sep 2, 2021

Thanks! Could you also update safety docs on ReadyToRunQueue::clear? (FuturesUnordered::clear -> FuturesUnordered::clear_head_all)

// # Safety
//
// - All tasks **must** have had their futures dropped already (by FuturesUnordered::clear)

@taiki-e taiki-e merged commit 37dfb05 into rust-lang:master Sep 2, 2021
@taiki-e taiki-e mentioned this pull request Nov 23, 2021
@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Nov 23, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
@taiki-e taiki-e mentioned this pull request Dec 18, 2021
taiki-e added a commit that referenced this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safety risk with reusing ReadyToRunQueue
2 participants