Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libgit2 to 1.4.0 #806

Merged
merged 2 commits into from Feb 15, 2022
Merged

Bump libgit2 to 1.4.0 #806

merged 2 commits into from Feb 15, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Feb 15, 2022

Closes #804.

@@ -120,7 +120,7 @@ pub use crate::reference::{Reference, ReferenceNames, References};
pub use crate::reflog::{Reflog, ReflogEntry, ReflogIter};
pub use crate::refspec::Refspec;
pub use crate::remote::{
FetchOptions, PushOptions, Refspecs, Remote, RemoteConnection, RemoteHead,
FetchOptions, PushOptions, Refspecs, Remote, RemoteConnection, RemoteHead, RemoteRedirect,
Copy link
Member Author

@dtolnay dtolnay Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API question: RemoteRedirect or Redirect? The libgit2 enum is called git_remote_redirect_t.

Copy link
Member

@alexcrichton alexcrichton Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think following libgit2 with RemoteRedirect is fine here

Copy link
Member

@alexcrichton alexcrichton left a comment

👍 Thanks!

@alexcrichton alexcrichton merged commit 509fe58 into rust-lang:master Feb 15, 2022
6 checks passed
@ehuss
Copy link
Collaborator

@ehuss ehuss commented Feb 15, 2022

Would it be possible to bump the version probe here?

@dtolnay dtolnay deleted the bump branch Feb 15, 2022
@extrawurst
Copy link
Contributor

@extrawurst extrawurst commented Feb 15, 2022

@ehuss @alexcrichton yeah lets bump that before we mark a release please

@extrawurst
Copy link
Contributor

@extrawurst extrawurst commented Feb 15, 2022

we probably need a release checklist in the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants