Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOptimize set union and intersection #130
+13
−3
Conversation
For intersection: take the smaller set, and check each element exists in the larger set. For union: take the larger set, and append missing elements from the smaller set. Similar optimizations exist in Rust's `HashSet`.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ Thanks! |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Nov 11, 2019
Optimize set union and intersection For intersection: take the smaller set, and check each element exists in the larger set. For union: take the larger set, and append missing elements from the smaller set. Similar optimizations exist in Rust's `HashSet`.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
stepancheg commentedNov 11, 2019
For intersection: take the smaller set, and check each element
exists in the larger set.
For union: take the larger set, and append missing elements from
the smaller set.
Similar optimizations exist in Rust's
HashSet.