Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use criterion for benches #243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

henryboisdequin
Copy link

Closes #4

rust-toolchain Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Amanieu
Copy link
Member

Amanieu commented Mar 3, 2021

You need to fix the CI failures. And restore the benchmark code that you deleted (the function are created by the macro_rules!, but you deleted it).

@bors
Copy link
Collaborator

bors commented Mar 14, 2021

☔ The latest upstream changes (presumably edeb8f7) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making benchmarks better
3 participants