don't merge test#718
Draft
0xdeafbeef wants to merge 1 commit into
Draft
Conversation
Contributor
|
Kind of confused why the stable |
Contributor
Author
Interpreting codegen is hard :) |
Contributor
|
Honestly, while I think that we should just use the stable version when available (as a reminder to use it when MSRV updates), this kind of feels well within the range of signal noise. Would probably trust some cachegrind benchmarks or just peeking at the generated code more, since those are much less susceptible to background noise, even though criterion tries its best. Also, using the internal |
Contributor
Author
i've disabled boost; pinned cpu etc. Regression quite big.
For example replacing with /// Brings [unlikely](core::intrinsics::unlikely) to stable rust.
#[inline(always)]
pub(crate) const fn unlikely(b: bool) -> bool {
#[allow(clippy::needless_bool, clippy::bool_to_int_with_if)]
if (1i32).checked_div(if b { 0 } else { 1 }).is_none() {
true
} else {
false
}
}Run - different unlikely variant; variant 2 - std cold path.
I'll return with valgrind later :) as bonus noop likeley:
|
Contributor
|
Mentioning rust-lang/rust#156863 for when you get back to this as another interesting thing to note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cold_pathwas stabilized so i wanted to test how will it affect codegen.It's a mixed bag but numbers are curious.