Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static websites hosting policy #25

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@pietroalbini
Copy link
Member

commented May 7, 2019

@pietroalbini pietroalbini force-pushed the static-websites branch from 9e1a654 to 4068912 May 7, 2019

@pietroalbini pietroalbini force-pushed the static-websites branch from 4068912 to 5fc87a1 May 7, 2019

@pietroalbini

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

@shepmaster added the rationale for each of the requirements.

Show resolved Hide resolved guidelines/static-websites.md Outdated
Show resolved Hide resolved guidelines/static-websites.md Outdated
Show resolved Hide resolved guidelines/static-websites.md Outdated
Show resolved Hide resolved guidelines/static-websites.md Outdated

pietroalbini added some commits May 8, 2019

@pietroalbini

This comment has been minimized.

Copy link
Member Author

commented May 11, 2019

Addressed all the comments from Alex and added a new section on fixing GitHub Pages redirects when it sits behind CloudFront.

@pietroalbini

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

commented May 15, 2019

Team member @pietroalbini has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@shepmaster
Copy link
Member

left a comment

Are the people who want the website supposed to do all of the deploy steps themselves? It feels odd that I need to “Create a CloudFront web distribution” to publish my github pages. Am I misreading?

Show resolved Hide resolved guidelines/static-websites.md Outdated
Show resolved Hide resolved guidelines/static-websites.md Outdated
@pietroalbini

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Are the people who want the website supposed to do all of the deploy steps themselves?

Nope, clarified the steps are meant to be executed by a member of the infra team.


```json
{
"github_pages_origin": "org-name.github.io/repo-name"

This comment has been minimized.

Copy link
@sgrif

sgrif May 16, 2019

This section seems a bit confusing since the config you're giving is the same as the "bad" behavior listed above.

This comment has been minimized.

Copy link
@pietroalbini

pietroalbini May 16, 2019

Author Member

That config snippet is actually correct since github_pages_origin should contain the GitHub Pages base URL (which is the origin from Cloudfront's point of view). Should I clarify a bit more the description before the snippet?

Show resolved Hide resolved guidelines/static-websites.md
@sgrif

This comment has been minimized.

Copy link

commented May 16, 2019

@rfcbot reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.