Skip to content

Conversation

@nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Sep 20, 2022

This PR proposes a lighterweight initiative process. The summary is this:

  • RFCs required for every major change.
  • Small changes that fit in a PR, have narrow impact, and are uncontroversial can skip the RFC process.
  • If you have a lang-team champion and an experienced implementor, you can start experimenting by just adding a feature gate, but you'll still need an RFC later.

I removed the old initiative pages and redirect them to the new summary.

I've uploaded a preview to http://smallcultfollowing.com/lang-team-2022-09-20-preview/

@nikomatsakis
Copy link
Contributor Author

@rust-lang/lang I updated some of the pages based on the meeting by adding FAQs and the like, hopefully capturing the spirit of what we were saying!

In particular I expanded the experimentation page to capture the idea of the two roles we see:

  • Experimentor (person doing the work)
  • Champion (from lang team, basically a liaison)

I said that these can be the same person, but in that case somebody else should second the PR that adds the feature gate.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikomatsakis during the meeting you had a diagram, but I don't see it here. Maybe you forgot to add it to the commit? (Edit: never mind, I totally managed to a review a small subset of the changes... somehow).

* Once you've found a champion, open a PR adding a new feature gate to the compile and create an associated tracking issue.
* The PR should include a write-up documenting the motivation and outline of what they are trying to achieve.
* The feature gate should be marked as 'experimental', so that users get warnings if they try to use it. This flag has to stay until an RFC is accepted, even if the implementation is in good shape.
* The lang-team champion will "second" the PR, starting an FCP. Once the FCP completes, the PR can land and implementation work begins (always gated under the new feature gate).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a regular FCP (i.e., rfcbot)? Or the new process we're thinking about?

(Or the not-actually-full-team checkbox kind of partially existing MCP FCP where it isn't tracked by automation)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was imagining this as using the new bot, but since that's not available, we should discuss how to achieve it. I would be fine with an interim process of "just use rfcbot", or of "just use rfcbot, but you can check all the boxes".

nikomatsakis and others added 12 commits September 21, 2022 15:01
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
@nikomatsakis
Copy link
Contributor Author

Pushed various updates, taking into account @Mark-Simulacrum's suggestions (thanks!).

@nikomatsakis
Copy link
Contributor Author

@rfcbot fcp merge

I'd like to get folks to review this and agree to it. We discussed it some in the meeting, and I don't think I really deviated from that, but nonetheless.

@rfcbot
Copy link

rfcbot commented Sep 23, 2022

Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@scottmcm
Copy link
Member

scottmcm commented Oct 1, 2022

Thanks for working all this out! The simplifications look like a good match for what often happens, and I like the emphasis on getting RFCs a bit more often than we have recently.

@rfcbot reviewed

@rfcbot rfcbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Oct 1, 2022
@rfcbot
Copy link

rfcbot commented Oct 1, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@pnkfelix
Copy link
Contributor

pnkfelix commented Oct 3, 2022

The current diagram sort of makes it confusing about whom the two boxes on the right side apply to. (Or, alternatively, it makes it confusing to whom the box on top, about "experienced contributor", is being directed at: Is it aimed at everyone, including people proposing small tweaks to existing features, or is it solely aimed at people proposing new features or other large changes?)

Maybe consider revising the diagram so that the "new feature, or complex change" box now has a "yes" arc that flows into the "experienced contributor" question box, and a "no" arc that flows into the "okay, this must be a small addition or tweak to existing feature box."

(The biggest reason I suggest this: the current diagram has that "experienced contributor" box at the top, and its easy for people to see that, and start there, without even noticing the other boxes on the side. This means experienced contributors may well overlook the fact that they need not open a tracking issue if they're talking about a minor change. Obviously if they read the text itself, they would see the alternative path you describe there, but I suspect many people may consult the diagram without looking much at the text.)


Having said that, I'm not registering this as a formal concern; its just a nitpick.

@nikomatsakis
Copy link
Contributor Author

I've pushed up some edits and resolved the concerns. I'm going to go ahead and merge this although the FCP has not expired, because I want to be able to link to it as I go through issues and do housekeeping.

@nikomatsakis nikomatsakis merged commit 644abff into rust-lang:master Oct 4, 2022
@rfcbot rfcbot added finished-final-comment-period to-announce Not yet announced MCP proposals and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge The FCP starter wants to merge (accept) this finished-final-comment-period T-lang to-announce Not yet announced MCP proposals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants