New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core::ffi::c_void is available since rustc 1.30 #1132

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@glandium
Contributor

glandium commented Nov 21, 2018

No description provided.

@rust-highfive

This comment has been minimized.

rust-highfive commented Nov 21, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@glandium

This comment has been minimized.

Contributor

glandium commented Nov 21, 2018

It should also be noted that there hasn't been a release of libc with the merged use of core::ffi::c_void, while it has been available for multiple weeks now, since it was part of 1.30. Could there be a libc release with this merged?

@gnzlbg

This comment has been minimized.

Collaborator

gnzlbg commented Nov 21, 2018

Could there be a libc release with this merged?

Sure I can do one. From #1082 and #1086 it appears that requiring 1.31 was an oversight, but I'll wait till @alexcrichton signs on that.

@glandium

This comment has been minimized.

Contributor

glandium commented Nov 21, 2018

from irc:

<Arnavion> It was marked as 1.31 because it was added in the 1.30 nightly, so there would be 1.30 nightlies that didn't have it
<Arnavion> But of course it also makes sense that it'll be in 1.30 stable, so it should be marked as 1.30
<Arnavion> Dunno how libc has done it in the past

@gnzlbg

This comment has been minimized.

Collaborator

gnzlbg commented Nov 21, 2018

That's pretty much what the #1082 PR message says.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Nov 21, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 21, 2018

📌 Commit fdb9726 has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented Nov 21, 2018

⌛️ Testing commit fdb9726 with merge e85479b...

bors added a commit that referenced this pull request Nov 21, 2018

Auto merge of #1132 - glandium:master, r=alexcrichton
core::ffi::c_void is available since rustc 1.30
@bors

This comment has been minimized.

Contributor

bors commented Nov 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e85479b to master...

@bors bors merged commit fdb9726 into rust-lang:master Nov 21, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment