New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tm struct members public #1183

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
5 participants
@xmclark
Copy link
Contributor

xmclark commented Dec 23, 2018

This PR makes the members of struct tm public.

I see no reason why these fields should not be public fields. They are public in the other targets. I did a blame and it seems that they have been private since added a couple years ago.

53e0d38

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Dec 23, 2018

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@xmclark xmclark changed the title WIP - make tm struct members public make tm struct members public Dec 23, 2018

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Dec 24, 2018

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 24, 2018

📌 Commit 1da1ffe has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 24, 2018

⌛️ Testing commit 1da1ffe with merge 76ce096...

bors added a commit that referenced this pull request Dec 24, 2018

Auto merge of #1183 - xmclark:make-tm-members-public-windows, r=gnzlbg
make tm struct members public

This PR makes the members of `struct tm` public.

I see no reason why these fields should not be public fields. They are public in the other targets. I did a blame and it seems that they have been private since added a couple years ago.

53e0d38
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 24, 2018

💔 Test failed - status-travis

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 24, 2018

@bors: retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 24, 2018

⌛️ Testing commit 1da1ffe with merge a4d4177...

bors added a commit that referenced this pull request Dec 24, 2018

Auto merge of #1183 - xmclark:make-tm-members-public-windows, r=gnzlbg
make tm struct members public

This PR makes the members of `struct tm` public.

I see no reason why these fields should not be public fields. They are public in the other targets. I did a blame and it seems that they have been private since added a couple years ago.

53e0d38
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: gnzlbg
Pushing a4d4177 to master...

@bors bors merged commit 1da1ffe into rust-lang:master Dec 24, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment