Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for sparc-unknown-linux-gnu #1567

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@glaubitz
Copy link
Contributor

glaubitz commented Oct 24, 2019

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Oct 24, 2019

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Oct 25, 2019

@rust-highfive rust-highfive assigned alexcrichton and unassigned gnzlbg Oct 25, 2019
@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Oct 25, 2019

Can we try to re-run the rust-lang.libc test? The failure seems unrelated.

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from e835296 to 25e71b1 Oct 25, 2019
@gnzlbg
gnzlbg approved these changes Oct 25, 2019
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Oct 25, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 25, 2019

📌 Commit 25e71b1 has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 25, 2019

⌛️ Testing commit 25e71b1 with merge 1b179f2...

bors added a commit that referenced this pull request Oct 25, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 25, 2019

💔 Test failed - status-azure

@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Oct 26, 2019

Looks like there are unrelated test failures for some tests. Would a manual merge be possible?

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Oct 27, 2019

Looks like there are unrelated test failures for some tests

Yes, looks like nightly Rust broke a couple of libc jobs. Need to fix that upstream.

Would a manual merge be possible?

Sadly no, all PRs are blocked on the build being green, too many crates depend on libc.

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from 25e71b1 to 90bf188 Nov 4, 2019
@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 6, 2019

@gnzlbg Any idea when the CI will be working again?

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from 90bf188 to f35ef37 Nov 18, 2019
@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 18, 2019

Just rebased and force-pushed, should be good for merge after CI has finished.

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from f35ef37 to 7b2e915 Nov 18, 2019
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 19, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit 7b2e915 has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

⌛️ Testing commit 7b2e915 with merge c881cac...

bors added a commit that referenced this pull request Nov 19, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

💥 Test timed out

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 19, 2019

@bors: retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

⌛️ Testing commit 7b2e915 with merge c23c911...

bors added a commit that referenced this pull request Nov 19, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 19, 2019

💔 Test failed - status-azure

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 20, 2019

@bors: retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 20, 2019

⌛️ Testing commit 7b2e915 with merge 9c6d085...

bors added a commit that referenced this pull request Nov 20, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 20, 2019

💔 Test failed - status-azure

@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 20, 2019

Same failure: same target and package that failed to download.

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 20, 2019

@bors: retry

Let's try one more time.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 20, 2019

⌛️ Testing commit 7b2e915 with merge fac614d...

bors added a commit that referenced this pull request Nov 20, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 20, 2019

💔 Test failed - status-azure

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from 7b2e915 to aede579 Nov 25, 2019
@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 25, 2019

Rebased and pushed. Let's see if the CI is happier today.

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from aede579 to 8b3b17f Nov 25, 2019
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 25, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 8b3b17f has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

⌛️ Testing commit 8b3b17f with merge a5b6656...

bors added a commit that referenced this pull request Nov 25, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

💔 Test failed - checks-cirrus-freebsd-11

@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 25, 2019

CI failed again for unrelated reasons :(.

@glaubitz glaubitz force-pushed the glaubitz:sparc-linux branch from 8b3b17f to 034574c Nov 25, 2019
@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 25, 2019

@gnzlbg Can you approve again?

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 25, 2019

Every time the source code is modified I need to review, and with the re-bases it is unclear to me what changed from the previous time I reviewed, so I kind of need to review all of it, which takes time. It would be simpler if new commits were independent commits.

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 25, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 034574c has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

⌛️ Testing commit 034574c with merge 7a12eed...

bors added a commit that referenced this pull request Nov 25, 2019
Add initial support for sparc-unknown-linux-gnu

While the Rust compiler already supports the sparc-unknown-linux-gnu target, the libc crate is missing support for it. Let's add it so that Rust can built for this target as well.
@glaubitz

This comment has been minimized.

Copy link
Contributor Author

glaubitz commented Nov 25, 2019

@gnzlbg I'm just rebasing every time and then force-pushing to retrigger the testsuite. No changes.

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

gnzlbg commented Nov 25, 2019

Ah, please don't do that. That re-triggers the test suite here, blocking the queue and preventing bors from trying to merge it, and requires re-reviewing the PR instead of just retrying it.

It's better just to ping me :)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 7a12eed to master...

@bors bors merged commit 034574c into rust-lang:master Nov 25, 2019
6 checks passed
6 checks passed
homu Test successful
Details
nightly x86_64-unknown-freebsd-10 Task Summary
Details
nightly x86_64-unknown-freebsd-12 Task Summary
Details
rust-lang.libc #20191125.11 succeeded
Details
rust-lang.libc (1) #20191125.9 succeeded
Details
stable x86_64-unknown-freebsd-11 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.