Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the ESP-IDF framework - 3 forgotten mappings #2396

Merged
merged 1 commit into from Sep 12, 2021

Conversation

@ivmarkov
Copy link

@ivmarkov ivmarkov commented Sep 12, 2021

When implementing the initial support for ESP-IDF a month ago, I managed to forget to properly decorate these 3 libc bindings for the ESP-IDF.

So now we are in the uncomfortable situation that using STD's TcpListener::bind results in a linkage error.

This PR is fixing this, as well as properly exposing two additional ESP-IDF APIs, implemented via LwIP.

@rust-highfive
Copy link

@rust-highfive rust-highfive commented Sep 12, 2021

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

Copy link
Member

@JohnTitor JohnTitor left a comment

Thanks for the follow-up!

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Sep 12, 2021

@bors r+

@bors
Copy link
Contributor

@bors bors commented Sep 12, 2021

📌 Commit 7e83ba0 has been approved by JohnTitor

@bors
Copy link
Contributor

@bors bors commented Sep 12, 2021

Testing commit 7e83ba0 with merge fe6531e...

@bors
Copy link
Contributor

@bors bors commented Sep 12, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing fe6531e to master...

@bors bors merged commit fe6531e into rust-lang:master Sep 12, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants