Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tvOS #2958

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Add support for tvOS #2958

merged 1 commit into from
Oct 13, 2022

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Oct 12, 2022

This is essentially identical to the iOS support, as the OS is... essentially identical to iOS.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Oct 12, 2022

📌 Commit bf618c9 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 12, 2022

⌛ Testing commit bf618c9 with merge 6bbdd71...

bors added a commit that referenced this pull request Oct 12, 2022
Add support for tvOS

This is essentially identical to the iOS support, as the OS is... essentially identical to iOS.
@bors
Copy link
Contributor

bors commented Oct 12, 2022

💥 Test timed out

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Oct 13, 2022

⌛ Testing commit bf618c9 with merge e4e865d...

@bors
Copy link
Contributor

bors commented Oct 13, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing e4e865d to master...

@bors bors merged commit e4e865d into rust-lang:master Oct 13, 2022
@thomcc
Copy link
Member Author

thomcc commented Oct 24, 2022

Mind cutting a release with this in it at some point soon? I'd like to add tvOS support to libstd.

@thomcc thomcc deleted the tvos-support branch October 24, 2022 05:59
@JohnTitor
Copy link
Member

Sure, I'll handle it after work.

@thomcc
Copy link
Member Author

thomcc commented Oct 24, 2022

Thanks! No rush!

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
Support Apple tvOS in libstd

This target has existed in the compiler for a while, was `no_std`-only previously (even requiring `#![feature(restricted_std)]`). Apple tvOS is essentially the same as iOS, down to using the same version numbering, so there's no reason for this to be a `no_std`-only target the way it is currently.

Not yet tested much (I have an Apple TV, but haven't tested that this can deploy and run programs on it, nor the simulator). Uses the implementation strategy as the watchOS support in rust-lang#98101 and etc. That is, no `std::os::` interfaces aside from those in `std::os::unix`.

Includes an update to libc in order to pull in rust-lang/libc#2958.
@lcruz99 lcruz99 mentioned this pull request Oct 3, 2023
bors added a commit that referenced this pull request Oct 5, 2023
Fix apple tvos support

This PR adds one missed conditional to support apple tvOS target, it complements #2958.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants