Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more MNT_ flags on {Dragonfly,Net,Open}BSD #2973

Merged
merged 3 commits into from
Oct 23, 2022
Merged

Add more MNT_ flags on {Dragonfly,Net,Open}BSD #2973

merged 3 commits into from
Oct 23, 2022

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Oct 22, 2022

No description provided.

@rust-highfive
Copy link

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

semarie
semarie suggested changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

several symbols in openbsd/mod.rs are already defined at upper level:

  • MNT_EXPORTED
  • MNT_UPDATE
  • MNT_RELOAD
  • MNT_FORCE

src/unix/bsd/netbsdlike/openbsd/mod.rs Outdated Show resolved Hide resolved
src/unix/bsd/netbsdlike/openbsd/mod.rs Outdated Show resolved Hide resolved
src/unix/bsd/netbsdlike/openbsd/mod.rs Outdated Show resolved Hide resolved
src/unix/bsd/netbsdlike/openbsd/mod.rs Outdated Show resolved Hide resolved
semarie
semarie approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for OpenBSD now. Thanks !

@JohnTitor
Copy link
Member

Could you add them on https://github.com/rust-lang/libc/tree/master/libc-test/semver?

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2022

📌 Commit 8acaac5 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 23, 2022

⌛ Testing commit 8acaac5 with merge cc19b6f...

@bors
Copy link
Contributor

bors commented Oct 23, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing cc19b6f to master...

@bors bors merged commit cc19b6f into rust-lang:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@semarie semarie semarie approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asomers @rust-highfive @JohnTitor @bors @semarie