Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a unique name for the Docker image used by CI. #3427

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Use a unique name for the Docker image used by CI. #3427

merged 1 commit into from
Nov 9, 2023

Conversation

Arnavion
Copy link
Contributor

@Arnavion Arnavion commented Nov 8, 2023

This allows testing multiple targets in parallel on the same host machine.

This allows testing multiple targets in parallel on the same host machine.
@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@Arnavion
Copy link
Contributor Author

Arnavion commented Nov 8, 2023

I needed this because I had to run CI locally for #3422 instead of having to wait for someone to approve it, and my machine has enough CPU and RAM to save time by running every target in parallel. It doesn't hurt to always do it even when running only one target as CI does, so I'm upstreaming it.

@JohnTitor
Copy link
Member

Makes sense, thanks! @bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2023

📌 Commit 90bd662 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 9, 2023

⌛ Testing commit 90bd662 with merge d0ce87b...

@bors
Copy link
Contributor

bors commented Nov 9, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing d0ce87b to main...

@bors bors merged commit d0ce87b into rust-lang:main Nov 9, 2023
11 checks passed
@Arnavion Arnavion deleted the unique-docker-image-name branch November 9, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants