Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal liblibc for Redox #439

Merged
merged 3 commits into from Nov 9, 2016

Conversation

Projects
None yet
3 participants
@jackpot51
Copy link
Contributor

jackpot51 commented Nov 3, 2016

This implements a minimal liblibc for Redox. Previously, this was talked about here: https://internals.rust-lang.org/t/redox-support-in-liblibc-and-libstd/3954

Merging this would allow Redox to port more Rust software, and will also allow libstd to be ported to Redox.

Changes to src/lib.rs are minimal, and the src/redox.rs file is also minimal but may be expanded in the future.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 3, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented Nov 3, 2016

This is in preperation for a much larger change in Rust's libstd, which can be seen in progress here: rust-lang/rust@master...redox-os:redox

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented Nov 7, 2016

@alexcrichton How does this look?

@jackpot51 jackpot51 referenced this pull request Nov 7, 2016

Merged

Add redox support #126

@alexcrichton alexcrichton merged commit 9195462 into rust-lang:master Nov 9, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented Nov 9, 2016

@alexcrichton Can a new cargo version be published?

@jackpot51 jackpot51 deleted the redox-os:redox branch Nov 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.