New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mipsel target_arches #445

Merged
merged 1 commit into from Nov 7, 2016

Conversation

Projects
None yet
3 participants
@xen0n
Copy link
Contributor

xen0n commented Nov 7, 2016

The mipsel target_arch was introduced with the initial MIPSel support (rust-lang/rust@82ec1ae), but was subsequently removed with implementation of the Flexible Target Specification (Rust RFC 0131, rust-lang/rust@3a8f4ec). Remove these to be consistent with other arches and reduce confusion.

I've very slightly formatted the deletions so as to not require a style cleanup later and obscure git blame output.

Remove mipsel target_arches
The `mipsel` `target_arch` was introduced with the initial MIPSel
support (rust-lang/rust@82ec1ae),
but was subsequently removed with implementation of the Flexible Target
Specification (Rust RFC 0131,
rust-lang/rust@3a8f4ec).
Remove these to be consistent with other arches and reduce confusion.

I've very slightly formatted the deletions so as to not require a style
cleanup later and obscure `git blame` output.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 7, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@xen0n

This comment has been minimized.

Copy link
Contributor

xen0n commented Nov 7, 2016

(I was confused by this myself, and this is why I incorrectly done #443 when, in fact, the problem was that [replace]s inside sub-Cargo.tomls (instead of the root-level one) are ignored, not picking up my changes.)

@alexcrichton alexcrichton merged commit b367659 into rust-lang:master Nov 7, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 7, 2016

Thanks!

@xen0n xen0n deleted the xen0n:remove-bogus-mipsel-arches branch Nov 7, 2016

bors added a commit to rust-lang/rust that referenced this pull request Nov 7, 2016

Auto merge of #37624 - xen0n:remove-bogus-mipsel-arches, r=alexcrichton
Remove mention of mipsel target_arch

This is the only remaining instance in rustc. All others were in the libc repo, removed with rust-lang/libc#445.

Actually there's more to clean in `libsyntax/abi.rs`, but let's save that for another commit...

Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment