Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse `#[link(cfg(..))]` in preparation for libstd #446
Conversation
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Nov 10, 2016
|
@alexcrichton: no appropriate reviewer found, use r? to override |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Nov 10, 2016
alexcrichton
merged commit 6e8c1b4
into
rust-lang:master
Nov 10, 2016
alexcrichton
deleted the
alexcrichton:link-cfg
branch
Nov 10, 2016
This was referenced Nov 16, 2016
This comment has been minimized.
This comment has been minimized.
|
This should not be architecture dependent. This way, the |
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedNov 10, 2016
In preparation for rust-lang/rust#37545 this is adding the appropriate
directives to libc to get included.