New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIPS: Layout refactor #453

Merged
merged 1 commit into from Nov 14, 2016

Conversation

Projects
None yet
2 participants
@xen0n
Copy link
Contributor

xen0n commented Nov 14, 2016

MIPS32 and MIPS64 userspaces are mostly the same save the obvious ABI difference, hence most of the const definitions could be shared.

This commit is not introducing any new significant additions, but mostly just shuffles the existing files around to make the directory structure more similar to the other, more mature platforms. The structs and extern fn definitions are not touched. Plus a couple of new consts for MIPS64 to match MIPS32 coverage:

  • RLIM_INFINITY
  • SYS_gettid

Passed libc-test on Gentoo MIPS64el (n64 ABI), on a Loongson 3A2000 box. The test suite itself needs some more love to actually compile cleanly on MIPS (ctest transitively depends on ancient libc version which doesn't build on MIPS), but let's save that for another day.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 14, 2016

Awesome, thanks! Want to rebase and I'll merge?

@xen0n xen0n force-pushed the xen0n:big-mips-shuffle branch from 93d3df4 to 6b72990 Nov 14, 2016

@xen0n

This comment has been minimized.

Copy link
Contributor

xen0n commented Nov 14, 2016

@alexcrichton Sure, done! 😹

@alexcrichton alexcrichton merged commit a3baaf6 into rust-lang:master Nov 14, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
MIPS: Layout refactor
MIPS32 and MIPS64 userspaces are mostly the same save the obvious ABI
difference, hence most of the const definitions could be shared.

This commit is not introducing any new significant additions, but mostly
just shuffles the existing files around to make the directory structure
more similar to the other, more mature platforms. The structs and extern
fn definitions are not touched. Plus a couple of new consts for MIPS64
to match MIPS32 coverage:

* `RLIM_INFINITY`
* `SYS_gettid`

Passed `libc-test` on Gentoo MIPS64el (n64 ABI), on a Loongson 3A2000
box. The test suite itself needs some more love to actually compile
cleanly on MIPS (`ctest` transitively depends on ancient `libc` version
which doesn't build on MIPS), but let's save that for another day.

@xen0n xen0n deleted the xen0n:big-mips-shuffle branch Nov 14, 2016

Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017

Auto merge of rust-lang#453 - nix-rust:asomers-kevent, r=posborne
Asomers kevent

This is a rebase of @asomers work on master to resolve a merge conflict so we can get things merged up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment