Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd rumprun CI and get tests passing #86
Conversation
alexcrichton
force-pushed the
alexcrichton:rumprun
branch
from
1e4d6c4
to
5856b1c
Dec 1, 2015
This comment has been minimized.
This comment has been minimized.
|
This is awesome. Looking at the code, I think we could use |
This comment has been minimized.
This comment has been minimized.
|
Yeah I've been meaning to get a NetBSD VM up and running to verify that these definitions are the same on NetBSD (there's a bunch of different ones), but I'll take your word for it for now! |
alexcrichton
force-pushed the
alexcrichton:rumprun
branch
6 times, most recently
from
ce47c21
to
3c6440c
Dec 1, 2015
alexcrichton
force-pushed the
alexcrichton:rumprun
branch
from
3c6440c
to
49d7bca
Dec 2, 2015
alexcrichton
added a commit
that referenced
this pull request
Dec 2, 2015
alexcrichton
merged commit 6a13db9
into
rust-lang:master
Dec 2, 2015
alexcrichton
deleted the
alexcrichton:rumprun
branch
Dec 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedNov 30, 2015
I was curious to see how we could get rumprun running over Thanksgiving, and it turns out it ended up working! I ended up having to fix a ton of definitions as well, and unfortunately I haven't been able to verify OpenBSD or Bitrig, so they may have broke as a result of this as well.
cc @gandro