This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable the PassInfo cache assertions to make the cache effective in builds with assertions enabld #34
Conversation
rust-highfive
assigned
brson
Feb 12, 2015
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Feb 12, 2015
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
alexcrichton
added a commit
that referenced
this pull request
Feb 12, 2015
alexcrichton
merged commit 458d7e4
into
rust-lang:rust-llvm-2015-02-09
Feb 12, 2015
TimNN
added a commit
to TimNN/llvm
that referenced
this pull request
Apr 17, 2017
TimNN
added a commit
that referenced
this pull request
Apr 17, 2017
TimNN
added a commit
that referenced
this pull request
Apr 23, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
May 3, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
May 20, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jun 3, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jun 16, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jun 21, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jun 27, 2017
arielb1
added a commit
that referenced
this pull request
Jun 27, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jun 28, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jul 9, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jul 9, 2017
vadimcn
added a commit
to vadimcn/llvm
that referenced
this pull request
Jul 10, 2017
TimNN
added a commit
that referenced
this pull request
Jul 20, 2017
TimNN
added a commit
that referenced
this pull request
Jul 20, 2017
alexcrichton
added a commit
that referenced
this pull request
Jul 30, 2017
alexcrichton
added a commit
that referenced
this pull request
Aug 4, 2017
alexcrichton
added a commit
that referenced
this pull request
Aug 15, 2017
alexcrichton
added a commit
that referenced
this pull request
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dotdash commentedFeb 12, 2015
Since the PassInfo cache does a regular, uncached, slow lookup for the
asserted condition, it's not very effective cough when assertions are
enabled. Since disabling these assertions gives quite a nice perf boost
and it's not really worse than the patch we had previously, let's just
do that.