Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the __private_api_log_lit special case #446

Merged
merged 1 commit into from Jan 24, 2021
Merged

Remove the __private_api_log_lit special case #446

merged 1 commit into from Jan 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2021

#445 (comment):

That special case existed to minimize the amount of code generated, but it's not compatible with format_args_capture as you pointed out. It should just be removed.

Closes #445.

I did not add a test for format_args_capture. I think I need to create a custom logger to capture records and add a testing-only crate feature or --cfg (to tell if #![feature(format_args_capture)] is allowed to use) to test it. format_args_capture is unstable now, I'm not sure if it worths it. Feel free to ask me to add such test if it's necessary.

It existed because of code size reasons, but it's incompatible with `format_args_capture`.
@ghost
Copy link
Author

@ghost ghost commented Jan 23, 2021

The CI failure looks like rust-lang/cargo#8517.

    Updating crates.io index
warning: spurious network error (2 tries remaining): error inflating zlib stream; class=Zlib (5)
warning: spurious network error (1 tries remaining): error inflating zlib stream; class=Zlib (5)
error: failed to get `cfg-if` as a dependency of package `log v0.4.13 (D:\a\log\log)`

Caused by:
  failed to load source for dependency `cfg-if`

Caused by:
  Unable to update registry `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  error inflating zlib stream; class=Zlib (5)
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant