Change with_renderer/with_preprocessor to overwrite #2802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests with with_renderer and with_preprocessor are used with extensions that have the same name.
This changes `with_renderer` and `with_preprocessor` to replace any extensions of the same name instead of just appending to the list. This is necessary for rust-lang's build process, because we replace the preprocessors with local ones. Previously, mdbook would just print an error, but continue working. With the change that preprocessors are no longer optional by default, it is now required that we have a way to replace the existing entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
with_rendererandwith_preprocessorto replace any extensions of the same name instead of just appending to the list. This is necessary for rust-lang's build process, because we replace the preprocessors with local ones. Previously, mdbook would just print an error, but continue working. With the change that preprocessors are no longer optional by default, it is now required that we have a way to replace the existing entries.