Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly use 48 bits for encoding timestamps and 32 bits for encoding thread IDs in RawEvent in order to make it smaller. #86
Conversation
This comment has been minimized.
This comment has been minimized.
Note to myself for tomorrow: Make event encoding endianess independent as part of this PR. |
4a0a5ff
to
01766c5
This comment has been minimized.
This comment has been minimized.
I added two commits:
The second commit makes the |
01766c5
to
c8c1e95
This comment has been minimized.
This comment has been minimized.
I went ahead and moved the last commit to a separate, less urgent PR (#88). This PR is ready for review. |
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michaelwoerister commentedNov 14, 2019
This restricts us to timestamps of at most ~78 hours after process start which seems acceptable.
The PR reduces the size of
RawEvent
(and thus the size of our event stream files) by 25%.