Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better way to ignore tests in Miri #1105

Merged
merged 2 commits into from Dec 7, 2019
Merged

better way to ignore tests in Miri #1105

merged 2 commits into from Dec 7, 2019

Conversation

@RalfJung
Copy link
Member

RalfJung commented Dec 7, 2019

This is better because it avoids warnings due to unused imports (the ignored tests still get compiled, just not executed).

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Dec 7, 2019

@oli-obk

This comment has been minimized.

Copy link
Collaborator

oli-obk commented Dec 7, 2019

Ooh, I love it

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

📌 Commit b883c11 has been approved by oli-obk

bors added a commit that referenced this pull request Dec 7, 2019
better way to ignore tests in Miri

This is better because it avoids warnings due to unused imports (the ignored tests still get compiled, just not executed).
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Testing commit b883c11 with merge 23fd44b...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

💥 Test timed out

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Dec 7, 2019

@bors retry (travis is under maintenance)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Testing commit b883c11 with merge 74c3ea5...

bors added a commit that referenced this pull request Dec 7, 2019
better way to ignore tests in Miri

This is better because it avoids warnings due to unused imports (the ignored tests still get compiled, just not executed).
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 74c3ea5 to master...

@bors bors merged commit b883c11 into rust-lang:master Dec 7, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@RalfJung RalfJung deleted the RalfJung:readme branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.