Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to ignore memory leaks #1106

Merged
merged 2 commits into from Dec 7, 2019
Merged

add flag to ignore memory leaks #1106

merged 2 commits into from Dec 7, 2019

Conversation

@RalfJung
Copy link
Member

RalfJung commented Dec 7, 2019

No description provided.

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Dec 7, 2019

@matklad said this would be useful... @oli-obk what do you think?

@oli-obk

This comment has been minimized.

Copy link
Collaborator

oli-obk commented Dec 7, 2019

While I'd prefer to have a more fine grained approach where we could mark individual allocs as leaked, this seems ok

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Dec 7, 2019

Let's leave that as "future work". ;)

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

📌 Commit e92d16d has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Testing commit e92d16d with merge 7b8e5e5...

bors added a commit that referenced this pull request Dec 7, 2019
add flag to ignore memory leaks
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

💔 Test failed - status-appveyor

@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Dec 7, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

📌 Commit 58ff21e has been approved by RalfJung

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Testing commit 58ff21e with merge 5277785...

bors added a commit that referenced this pull request Dec 7, 2019
add flag to ignore memory leaks
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

💔 Test failed - status-appveyor

@RalfJung RalfJung force-pushed the RalfJung:memleak-ignore branch from 58ff21e to 0a63637 Dec 7, 2019
@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Dec 7, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

📌 Commit 0a63637 has been approved by RalfJung

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

⌛️ Testing commit 0a63637 with merge 3cc6795...

bors added a commit that referenced this pull request Dec 7, 2019
add flag to ignore memory leaks
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 3cc6795 to master...

@bors bors merged commit 0a63637 into rust-lang:master Dec 7, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@RalfJung RalfJung deleted the RalfJung:memleak-ignore branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.