Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support main functions with Result return type #1125

Merged
merged 1 commit into from Dec 23, 2019

Conversation

@RalfJung
Copy link
Member

RalfJung commented Dec 23, 2019

Turns out we already properly create the substitution to call the libstd start-fn with an appropriate main, we just had an overzealous check in the way.

Fixes #1116.

@oli-obk

This comment has been minimized.

Copy link
Collaborator

oli-obk commented Dec 23, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 23, 2019

📌 Commit e325ad2 has been approved by oli-obk

bors added a commit that referenced this pull request Dec 23, 2019
support main functions with Result return type

Turns out we already properly create the substitution to call the libstd start-fn with an appropriate `main`, we just had an overzealous check in the way.

Fixes #1116.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 23, 2019

⌛️ Testing commit e325ad2 with merge 2a08c63...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 2a08c63 to master...

@bors bors merged commit e325ad2 into rust-lang:master Dec 23, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@RalfJung RalfJung deleted the RalfJung:main-result branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.