remove compatibility code for passing miri flags via cargo arguments #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2021
|
@oli-obk any objections to merging this? |
|
@bors r+ |
|
📌 Commit eaba4b2 has been approved by |
|
☀️ Test successful - checks-actions |
This was referenced Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1540, we deprecated
cargo miri test -- -Zmiri-disable-stacked-borrowsas a style of passing flags to Miri, introducingMIRIFLAGS="-Zmiri-disable-stacked-borrows" cargo miri testinstead. This madecargo mirimore compatible withcargo; both now behave the same in terms of argument parsing.However, to avoid breaking things, I introduced some backwards compatibility hack such that the old way would still work. Six months later, I think it is time to remove that hack.