Throw UB if f*_fast intrinsic called with non-finite value #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch! Yes I agree this makes sense. |
RalfJung
reviewed
May 3, 2021
Member
|
Looking great, thanks. :) |
Contributor
|
📌 Commit e0e59f6 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling these intrinsics with non-finite values is undefined behaviour, since they result in
f*intrinsics in LLVM with thefastflag, andfastmath on non-finite values results inpoisonvalues. (technically LLVM only considers it UB upon using the value, but that shouldn't make much of a difference)