Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Intrptrcast by default #851

Merged
merged 7 commits into from Jul 24, 2019

Conversation

@RalfJung
Copy link
Member

commented Jul 23, 2019

As laid out in #785: we change Miri to always have an RNG, seeded per default with 0. Then we adjust everything to remove dead code and dead tests.

r? @oli-obk
Cc @christianpoveda

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

r=me with the comment updated to explain what is meant by "nondeterministic"

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

📌 Commit 758d88b has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

⌛️ Testing commit 758d88b with merge 1e5264f...

bors added a commit that referenced this pull request Jul 24, 2019

Auto merge of #851 - RalfJung:intrptrcast-by-default, r=oli-obk
enable Intrptrcast by default

As laid out in #785: we change Miri to always have an RNG, seeded per default with 0. Then we adjust everything to remove dead code and dead tests.

r? @oli-obk
Cc @christianpoveda
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

💔 Test failed - status-appveyor

@RalfJung

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

Network failure.

@bors retry

bors added a commit that referenced this pull request Jul 24, 2019

Auto merge of #851 - RalfJung:intrptrcast-by-default, r=oli-obk
enable Intrptrcast by default

As laid out in #785: we change Miri to always have an RNG, seeded per default with 0. Then we adjust everything to remove dead code and dead tests.

r? @oli-obk
Cc @christianpoveda
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

⌛️ Testing commit 758d88b with merge 310649b...

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 310649b to master...

@bors bors merged commit 758d88b into rust-lang:master Jul 24, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@RalfJung RalfJung deleted the RalfJung:intrptrcast-by-default branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.