Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misssing 'roundf32' and 'roundf64' intrinsics #885

Merged
merged 2 commits into from Aug 4, 2019

Conversation

@Aaron1011
Copy link
Contributor

commented Aug 4, 2019

No description provided.

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Looks good, but please add a testcase (or rather, extend the existing FP testcase in tests/run-pass/intrinsics-math.rs).

@Aaron1011

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

@RalfJung: Updated

@RalfJung

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

📌 Commit 4c11c6b has been approved by RalfJung

bors added a commit that referenced this pull request Aug 4, 2019

Auto merge of #885 - Aaron1011:fix/f-round, r=RalfJung
Add misssing 'roundf32' and 'roundf64' intrinsics
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

⌛️ Testing commit 4c11c6b with merge 96adbf6...

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 96adbf6 to master...

@bors bors merged commit 4c11c6b into rust-lang:master Aug 4, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.