Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easy win: use the fx hasher when interning #131

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@lqd
Copy link
Contributor

commented Sep 26, 2019

This improves data loading by 13% on clap (yes, a whopping 23ms).

(I'm not especially chasing milliseconds in polonius-bin, I mostly wanted to remove these interning hot spots from clogging performance profiling results :)

@lqd lqd force-pushed the lqd:EZ-winz branch from ad4ac68 to 358b506 Sep 26, 2019
@nikomatsakis nikomatsakis merged commit b688fb5 into rust-lang:master Oct 3, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@lqd lqd deleted the lqd:EZ-winz branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.