Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd security page #123
Conversation
rust-highfive
assigned
pcwalton
May 15, 2015
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
May 15, 2015
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
jruderman
reviewed
May 15, 2015
| hours indicating the next steps in handling your report. If you would like, you | ||
| can encrypt your report using <a href="rust-key.gpg.ascii">our public key</a>. | ||
| This key is also <a | ||
| href="https://pgp.mit.edu/pks/lookup?op=vindex&search=0xEFB9860AE7520DAC">On |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
reedloden
May 24, 2015
It needs to be & instead of &, as it's part of an HTML attribute. In fact, if you open up http://www.rust-lang.org/security.html in Firefox and view the source, you'll see the & is highlighted in red right now because it's invalid.
This comment has been minimized.
This comment has been minimized.
steveklabnik
May 24, 2015
Author
Member
I feel... really dumb. I guess I'm so used to frameworks generating this for me, that I always thought it would need to be escaped in text, but not as part of an <a>. https://validator.w3.org/check?uri=http%3A%2F%2Fwww.rust-lang.org%2Fsecurity.html&charset=%28detect+automatically%29&doctype=Inline&group=0 points this out too.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimonSapin
May 25, 2015
Contributor
For what it’s worth, it’s an authoring requirement in the HTML spec to escape & there, but there’s also a implementation requirement in the spec for parsers to fix it up so that the end the result is the same. So the concern is mostly theoretical.
jruderman
reviewed
May 15, 2015
|
|
||
| <ul> | ||
| <li>Contact the current security coordinator (<a href="mailto:steve@steveklabnik.com">Steve Klabnik</a> (<a href="https://pgp.mit.edu/pks/lookup?op=vindex&search=0xDAE717EFE9424541">public key</a>)) directly.</li> | ||
| <li>Contact the back-up contact (<a href="mailto:andersrb@gmail.com"></a> (<a href="https://pgp.mit.edu/pks/lookup?op=vindex&search=0x16457A6368CFF26F">public key</a>)) directly.</li> |
This comment has been minimized.
This comment has been minimized.
jruderman
reviewed
May 15, 2015
| descriptive subject line to avoid having your report be missed. After the | ||
| initial reply to your report, the security team will endeavor to keep you | ||
| informed of the progress being made towards a fix and full announcement. As | ||
| recommended by <a href="http://en.wikipedia.org/wiki/RFPolicy">RFPolicy</a>, |
This comment has been minimized.
This comment has been minimized.
jruderman
reviewed
May 15, 2015
| can take:</p> | ||
|
|
||
| <ul> | ||
| <li>Contact the current security coordinator (<a href="mailto:steve@steveklabnik.com">Steve Klabnik</a> (<a href="https://pgp.mit.edu/pks/lookup?op=vindex&search=0xDAE717EFE9424541">public key</a>)) directly.</li> |
This comment has been minimized.
This comment has been minimized.
jruderman
May 15, 2015
Having to combine a mailto link with a separate public key link seems suboptimal. Is there a way to include a public key in a mailto link? Or could you provide a web-based form?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bluss
commented
May 24, 2015
|
Can we spell out explicitly that anything allowing breaking memory safety in safe rust code is a security issue? It's unclear to me if the intention is just rustc & other applications and regular security holes in them (what that would be) or something more directly relating to the safety properties of the language itself. Also: Does it in that case apply to only the stable channel, or other channels too? If I don't get it, others might be confused as well. |
This comment has been minimized.
This comment has been minimized.
|
@bluss I wanted to make the topic of what should be a security bug be an RFC we discuss, but have this page up in the meantime. |
This comment has been minimized.
This comment has been minimized.
|
@brson other than the few nits, are you okay with merging this? |
This comment has been minimized.
This comment has been minimized.
|
@steveklabnik yes |
steveklabnik
force-pushed the
steveklabnik:security
branch
from
b588fda
to
d372044
May 24, 2015
steveklabnik
added a commit
that referenced
this pull request
May 24, 2015
steveklabnik
merged commit 8e72a1f
into
rust-lang:gh-pages
May 24, 2015
This comment has been minimized.
This comment has been minimized.
|
I merged this so we could see http://www.rust-lang.org/security.html , but it's not linked from anywhere yet. @jruderman , after I hear from you regarding the escaping issue, i'll make another PR linking it from the homepage. |
steveklabnik commentedMay 15, 2015
Not quite ready to merge. We need the notifications mailing list, and for #120 to link to it, so we'll probably merge this shortly after that lands.