Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upOverhauled download page #187
Conversation
brson
added some commits
Sep 4, 2015
rust-highfive
assigned
nikomatsakis
Sep 11, 2015
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Sep 11, 2015
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Another niggle: the spacing around the download labels is a little imperfect. I might extend the buttons to the left by another column. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@brson Consider making the 'source' and 'doc' buttons twice as wide and stacking them vertically. May make them more visually distinct. Also instead of 'A beta of the upcoming stable release', 'A preview of the ...'. That way you aren't repeating 'beta'. |
This comment has been minimized.
This comment has been minimized.
|
The blue for the stable version header but black for the beta/nightly was a little off for me, perhaps the words "current stable release" could be a link to the release announcement? (or perhaps just the date?) With only one download medium per platform we may also be able to drop the file extensions of what you're actually downloading as it's not giving you much other info now. I like the idea of source/doc buttons being twice as wide, but perhaps the doc button should be a link in the description area? It's not necessarily a "let's download some stuff" button. (just a passing idea) |
This comment has been minimized.
This comment has been minimized.
|
Oh and one other thought I just remembered, we may want to make sure to design in space to put links to MSVC builds for Windows, those are basically ready-to-go on nightly and basically-ready-to-go on beta right now, so we could plausibly be putting those links up pretty soon. |
This comment has been minimized.
This comment has been minimized.
|
I like it. |
This comment has been minimized.
This comment has been minimized.
|
Nice work, @brson! I agree with most of what @alexcrichton said, though I think we should keep the extensions in the labels. It would also be nice to move the labels closer to the download buttons, somehow. (Previously, the text was longer so the layout worked a bit better.) Could the top release say "Stable" for consistency with the other channels? Also, I note that we don't give the patch number on the beta or nightlies, we should make this consistent as well. I have mixed feelings about the centered |
This comment has been minimized.
This comment has been minimized.
|
I'm curious what people think of the name 'Downloads' and 'downloads.html' for this page instead of 'Install' / 'install.html'. The thinking was that it made this page more flexible, but while I was reading this page I was thinking 'release channels ... this is a page about release channels'. Calling the page 'Release Channels' though is terrible. |
This comment has been minimized.
This comment has been minimized.
|
Regarding the patch number my thinking was that there won't ever be a patch number for beta/nightly, and also that it makes those channels seem less significant than stable, like 'this isn't Rust 1.4.0; this is something 1.4-ish'. Similar reason for not putting 'Stable' in the first section - makes it stand out as different. I'll try some adjustments. |
This comment has been minimized.
This comment has been minimized.
|
@brson I prefer "Downloads" to "Install". Another option might be "Releases", but it's slightly less obvious that you go there to get downloads. |
This comment has been minimized.
This comment has been minimized.
|
I don't have too much of a preference on naming, a slight inclination for "Install" over others, but not really that much. |
This comment has been minimized.
This comment has been minimized.
|
Why not |
This comment has been minimized.
This comment has been minimized.
Really long line lengths are harder to read, so it's common to provide a maximum width. |
This comment has been minimized.
This comment has been minimized.
|
Fine with me, but it either shouldn't be capped in pixels or adapt to higher-pixel-width screens. One solution would be to make the media query based on |
This comment has been minimized.
This comment has been minimized.
|
I'm terrible at front-end, so I don't know what the right thing is, but the studies on this are in terms of the length of words. So it would involve making sure that the right sized front at the right resolution isn't too long. |
brson
added some commits
Sep 21, 2015
This comment has been minimized.
This comment has been minimized.
|
Here's another revision. This is uploaded to the same place so you can't compare with the previous.
I did try to compress the curl snippets to small width again by wrapping the lines. This isn't very usable though because it forces your copied commands to contain a line break, which sucks to edit after pasting. The command needs to fit on one line. We could keep the old design where the code block scrolls, but it's pretty unaesthetic. We could also make the command smaller by adding e.g. |
This comment has been minimized.
This comment has been minimized.
|
Looks good to me! |
This comment has been minimized.
This comment has been minimized.
|
I may try one more that adds the channel name and full version to all three. |
brson commentedSep 11, 2015
This implements RWIB 8.
This is what it looks like.
The key things here are:
I'm reasonably happy with this. The only things aesthetically that I don't love are: