RWIB Mission 2, Community Page

[ghost]

r? @brson

1. removed links on front page, and replaced with 'news', 'community link' and 'legal'
2. Major changes to Community page
3. Added How_to_Contribute_page, mainly based on http://www.ncameron.org/rust.html. It includes mostly links to issues.
4. Added User_Group page

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[brson]

First impression looks good.

I like that you modified the navbar to include the community page until it gets its own redesign.

The 'legendary dedication' link: I was thinking something like http://techwhirl.com/conference-report-friendly-diverse-rust-camp/, though I really wanted like one glowing HN comment that could be directly linked. @steveklabnik do you have maybe a single tweet somewhere with glowing praise for the rust community?

The #rust-webdev and #rust-offtopic links are broken.

The description of #rust-internals includes the phrase 'for questions about how rust works'. I think this is too open to interpretation - we want general questions to go elsewhere, leaving internals for work. Maybe rephrase it to be more like 'To get involved of the development of Rust itself...'.

I'd also list #rust-internals second in the list, after #rust, since it's still sort of the primary entry point for internals discussion.

In addition to #rustc and #rustc-libs, I'd also suggest listing #rust-tools and #rust-lang. These four channels are the 'home' of the compiler team, libs team, tools team, and language team, respectively. Can you try indicating that in the descriptions, with links to the appropriate section on the team page?

Rust moderation team links to the team in the header as well as the description. Instead of the in-paragraph link to the team again perhaps 'contact' can be the link to their email.

Wow, you've written an entire contributing page too. Great start! Can you rename it to simply contributing.html and add a link to your modified navbar? A lot to think about here... I may be inclined to merge it as-is and circle back to think about it harder later. cc @nrc

"The comunity team is responsible for helping to upholding the code of conduct". Grammar typo.

Seems like internals.rust-lang.org should be included as well.

Well, this is pretty great. Thanks a lot :)

[brson]

"Our code of conduct must be observed in all matters relating to Rust online." This sentence is very important, but it's both strong ('must') and vague ('all matters'). I don't have a concrete suggestion right now but I'll think about it.

[ghost]

Thanks @brson, Wouldn't 'contributing.md' be too close to 'CONTRIBUTING.md'?

[brson]

Oh, huh. I didn't realize we had a 'contributing' file for the website. That is a drag. It sure seems like 'contributing.html' is a better name for the website page.

Edit: Urgh. I don't have better suggestions off hand.

[ghost]

I'm waiting on 'legendary dedication' link. Put the techwhirl link in temporarily.

[aturon]

@EFindlay Thanks so much for doing this! I have a bunch of feedback, but think it might be easiest to give as a branch/PR against what you have here. Would that be ok with you?

[ghost]

@aturon That's OK with me.

[brson]

Waiting on @aturon's feedback.

[aturon]

@EFindlay Thanks again for the hard work on this! I've opened a PR with my editing pass: https://github.com/efindlay/rust-www/pull/1

cc @brson

I focused only on the new community page, and haven't looked carefully at the contributing page yet.

[aturon]

BTW, once we've finished up the first round of feedback/edits, I think we should link to this PR in the Rust subreddit and/or discuss forum to get more eyeballs. I suspect most people aren't watching this repo closely.

[Manishearth]

we link to [contribute] twice here, reads a bit strange

[Manishearth]

So, I'm planning to have a generic "contribute to the Rust ecosystem" page as well. We probably should make this one more specific ("Contribute to the Rust compiler"); my page is not going to have major details about rustc itself.

[Manishearth]

(Or I can do this renaming later, really. No biggie)

[brson]

I'd prefer just one contributing page.

[ghost]

Mission 5, Documentation Page

1 Copied over documentation page.
2 Cleaned and fixed links.
3 Checked that there were no links to the old documentation page that needed to be changed.

(This should probably have been a new issue but I'm not sure how I could have done that.)

[brson]

I've posted the branch as it is now to my own gh page for easier review.

OK, so this covers #2 - community page, #3 - contributing, and now also #5 - docs. This is a lot to digest :)

We agree there is going to be more follow up on the contributing page at least, so we don't need to make it (or anything really) perfect right now, as long is its presentable.

I'll try to get some more eyes on this, but some quick additional notes:

• Since this does add a contributing page I'd like to go ahead and stuff it in the navbar, even if we are going to redisign it still.
• 'We also have a twitter account' is terminated with a comma, should be a period.
• The reformatting paragraphs of IRC channels continue to contain inline dashes like a bulleted list. These are weird and I suggest removing them.
• The stylistic difference between h2 and h3 is very subtle. I'd like to try to make them more distinct.
• On the usergroups page, 'meetings are ... very informal'. Suggest removing 'very', filler word. Perhaps combine with the following sentence: 'meetings are usually informal and open to everyone', removing the 'monthly' assertion, since I'm not confident it generally holds.
• On the usergroups page, 'rust_www' i'd change to either 'rust-www' to match the repo name, or maybe just 'the website'.
• Try including the calendar again on the usergroups page, indicating that meetups are often listed there, perhaps even suggesting to contact the community team to add events.

The docs page needs to expose the docs for all three channels, since the front-page navbar links are going to disappear in favor of this page.

I think the 'community and getting help' section of the docs page can go away since we've got the community page also covering that content.

The faq link on the doc page goes to a weirdly formatted url of a page that doesn't exist.

Will you consider splitting the docs page into its own PR? It is going to require more work still than the community page, and I think it will be easier to review and move forward with them separate.

I still haven't looked closely at the contributing page, but it looks like a reasonable start.

[aturon]

I'd like to second @brson's request to have one PR per RWIB mission. I think that makes it a lot easier to get feedback and reach consensus, and allows us to start landing pieces independently.

[ghost]

Thanks for all the feedback! Bear with me on the separate PRs. I thought I made a separate PR but it didn't work out that way. I might need to do a little research to figure out how to sort it out.

[ghost]

It looks like I need to make separate branches for each Mission (Stack Overflow). For Mission 3 Contributing Page and Mission 5 Documentation Page I will need to make PRs against new branches.

[edunham]

@EFindlay, this is looking amazing! Sorting commits into separate PRs is one of the more complex "features" of GitHub.

One fix would look something like this; easier if you want to mess around with fancy git ranges when cherry-picking. You'd run these commands after git cloneing your repo onto your laptop and cding into the directory where you cloned it.

$ git checkout 9f51aec7640ea7731779bf511e71ed9a9997259f #we're making a new branch that's even with rust-lang/rust-www master
$ git checkout -b mission3 # now we're on a branch named mission3
$ git cherry-pick abc123 # repeat for the hash of each commit you made for mission 3
$ git push origin mission3 # assuming your fork of the repo is the origin; `git config -l` to check
$ git checkout 9f51aec7640ea7731779bf511e71ed9a9997259f # back to rust-lang/rust-www master
$ git checkout -b mission5
$ git cherry-pick abc123 # again, repeat for each commit in your mission5 changes
$ git push origin mission5
$ git checkout abc123 # use the hash of the last commit in your mission 2 changes
$ git push --force origin master # overwrite the branch that this PR is from with only the mission 2 stuff

Rather than force-pushing to master, you could replace the final command with

$ git checkout -b mission2
$ git push origin mission2

and then create a new mission2 PR from the branch you just pushed.

Now this PR would only show the mission 2 changes (since it's from your master branch, and you reset the master branch with the final command) and you'd have mission3 and mission5 branches to create separate PRs from. When you visit the main rust-lang/rust-www page after pushing mission3 and mission5, it'll say "you recently pushed branches" at the top and give you a button for creating those PRs.

[ghost]

@edunham, thanks for your help. I'm still working on it ...

[brson]

Looks like this is superceded by #201