Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions page #229

Closed
wants to merge 10 commits into from

Conversation

Projects
None yet
10 participants
@brson
Copy link
Contributor

brson commented Nov 30, 2015

Based off of @efindlay's original PR, which was based off ncameron's work.

Rendered.

The idea here is to quickly provide the most important links (e.g. the second paragraph reroutes people to bug reporting), subdivide the deluge of information in a way that is digestible (six sections - issue triage, docs, community building, tooling, libs, compiler), then guide people to other sources of information. I've used prose in an attempt to provide context for newbies to understand the larger picture. Sometimes the same information is provided in different sections, from different perspectives - e.g. fixing easy issues vs. writing easy issues.

Ideally, there is an easy path from here to all relevant information for contributors, but that is not quite true yet, and there are types of information that are just not available. What I want this page to do is to link to other, 'living', landing pages for teams, initiatives, topics, etc., and I've tried to do that as much as possible, but there are some categories of information that are not organized anywhere, so sometimes there is more exposition here than I'd like.

This page occasionally links to, and thus endorses, unofficial projects of interest. I want to be clear though that it is not a free-for-all and we are not open to listing arbitrary projects here.

With the quantity and specificity of info here it'll be prone to bitrot and need periodic attendance.

Problems:

  • The prominent link to 'an overview of the organization, processes, and policies' links somewhere uncomprehensive. I'd like to write this, but there's a lot of info to cover and I want a break from writing for a bit.
  • Topics of blogging and translation aren't covered.
  • #rust-libs may not be the right place to direct people who are interested in out-of-tree libs.

I've run out of steam on this and want to get other eyes on it. The libs and tooling sections were the last I hit and it shows.

Although they are very different, my main influence was Scala's page.

Fixes #177.

cc @aturon @steveklabnik

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 30, 2015

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson force-pushed the brson:contributions branch from 8c3532d to d5b89cf Nov 30, 2015

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Nov 30, 2015

This links to the IDEs page, which I have not updated to fit the style of the site. My preference is to move that content to the dungeon/forge.


On `E-mentor` issues an experienced Rust developer has volunteered in
the comments to mentor you through the solving the issue and
[submitting the fix GitHub pull request][pull]. Contact them about the

This comment has been minimized.

@badboy

badboy Nov 30, 2015

Member

This sentence needs fixes. I guess at least the solving the issue and submitting the fix GitHub pull request should be changed.

This comment has been minimized.

@brson

brson Dec 4, 2015

Author Contributor

Wow, what happened...

of it. If you're not sure how to get involved, then this page
will help.

**Just want to report a bug in Rust?** [Follow the bug reporting

This comment has been minimized.

@steveklabnik

steveklabnik Nov 30, 2015

Member

I would try to rephrase this to lose the "just", the whole point of these pages is that doing this isn't always as obvious as it may seem. Maybe something like "Found a bug and need to report it?"

On `E-mentor` issues an experienced Rust developer has volunteered in
the comments to mentor you through the solving the issue and
[submitting the fix GitHub pull request][pull]. Contact them about the
issue, on the issue tracker by [@mentioning] their name, on IRC, or

This comment has been minimized.

@steveklabnik

steveklabnik Nov 30, 2015

Member

"their name in a comment"

## Documentation

Documentation is never good enough and there's never enough of it,
writing documentation is a valuable way to contribute. Many aspects of

This comment has been minimized.

@steveklabnik

steveklabnik Nov 30, 2015

Member

I would maybe split that first sentence into two, or use a ; rather than a , after "it"

This comment has been minimized.

@brson

brson Dec 4, 2015

Author Contributor

The second clause is self-evident and content free, so I think I'll just remove it.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Nov 30, 2015

An idea I liked but didn't implement, mainly because it would add even more stuff, is to put an 'active initiatives' section near the front, that would link to things like the forum posts for RWIB, Glacier, IDEs, MIR, etc. Curious what others think.

[rust-rosetta]: https://github.com/Hoverbear/rust-rosetta
[rustc-guide]: https://github.com/rust-lang/rust/blob/master/src/librustc/README.md
[rustc-perf]: http://ncameron.org/perf-rustc/
[rustc-tour]: http://tomlee.co/2014/04/03/a-more-detailed-tour-of-the-rust-compiler/

This comment has been minimized.

@steveklabnik

steveklabnik Nov 30, 2015

Member

This post is great, but so old: is it even relevant today?

This comment has been minimized.

@brson

brson Dec 4, 2015

Author Contributor

Maybe not. I'll remove it.

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Nov 30, 2015

👏 👏 👏

@nodakai

This comment has been minimized.

Copy link

nodakai commented Nov 30, 2015

Are we required to read through both of the new contributing.html and the existing CONTRIBUTING.md ? I don't think we need both.

title: Contributing to Rust · The Rust Programming Language
---

# Contributing to Rust

This comment has been minimized.

@nodakai

nodakai Nov 30, 2015

"Contributing to Rust" carries next to no information. Instead I'd emphasize

There are many ways to contribute to the success of Rust.

because, as I understand it, this document is intended for people who are eager to contribute to Rust but have no idea on where to start.

This comment has been minimized.

@brson

brson Dec 4, 2015

Author Contributor

What might be a more descriptive title?

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 30, 2015

@englishm

This comment has been minimized.

Copy link

englishm commented Dec 1, 2015

How might people with UX or visual design backgrounds be able to contribute to Rust?

Once you've found your way around the project and have created a few
pull requests in a particular area, consider reviewing others' pull
requests: good reviewership is a rare skill and always appreciated. No
prior permission is needed &emdash; just start constructively and politely

This comment has been minimized.

@iliekturtles

iliekturtles Dec 2, 2015

Contributor

The &emdash; is not rendering properly: search for "emdash" at http://brson.github.io/rust-www/contribute.html

This comment has been minimized.

@brson

brson Dec 4, 2015

Author Contributor

Oops. Should be mdash.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 4, 2015

Are we required to read through both of the new contributing.html and the existing CONTRIBUTING.md ? I don't think we need both.

CONTRIBUTING.md is displayed on new PRs - it catches people who are familiar with the GitHub ecosystem but not the Rust project. It is also specific to the mechanics of contributing to the rust-lang/rust repository. This page is much broader in scope and links to CONTRIBUTING.md as appropriate for the details.

The content is mostly not duplicated, but I think we can trim down CONTRIBUTING.md.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 4, 2015

How might people with UX or visual design backgrounds be able to contribute to Rust?

@englishm Unfortunately, we don't have an answer for this right now. We're hoping to put some planning effort into this area soon so we can give better guidance. If somebody is aware of anything we can tell such people or point them toward that would be productive, I'd be interested.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 4, 2015

I've addressed the current feedback except for @nodakai's concern about the title.

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Dec 4, 2015

I want to give more in-depth feedback, but for now, my biggest concern is that there's just too much here -- that the page is a bit overwhelming.

Can we think of a way to pull out the most juicy bits into a TL;DR section we can stick at the front? I know triage is acting as part of that, but I'm thinking something even tighter.

Note that the Scala site avoids this problem by having all of the sections actually be independent pages. We could consider that as well.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 4, 2015

@aturon Yeah, it's a lot. Do you think that the six areas are a reasonable subdivision?

@bstrie has previously expressed an opinion against subpages.

I'll try reorganizing it so this page is less sprawling, with the bulk of the information elsewhere.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 4, 2015

cc @nrc you may have opinions about this.

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Dec 4, 2015

@brson Yes, I think the structure and content is great. Just hoping we can get something a bit more inviting a la http://scala-lang.org/contribute/

@nrc

This comment has been minimized.

Copy link
Member

nrc commented Dec 6, 2015

+1 for subpages - I think it will help make the page feel less overwhelming. Design-wise, I think having more whitespace and a less dense layout will make this feel better, and that is easier with sub-pages, if the landing page has just a few paras of text and some links, it's easier to space it out.

@brson brson force-pushed the brson:contributions branch from d95698b to aa38474 Dec 22, 2015

@brson brson force-pushed the brson:contributions branch from aa38474 to 1bb607f Dec 22, 2015

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 22, 2015

OK, I've split each of the 6 subsections into their own pages. See here.

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Dec 23, 2015

@brson Very nice! I feel like that really makes this whole effort come together.

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Dec 31, 2015

One further suggestion: make the links to the subsections stand out a bit -- perhaps bold? There are a lot of links here so emphasizing the primary ones is helpful. (See, again, the Scala page for inspiration here.)

Few tweaks
Add link to Manish's new blog post on mentorship.

Bolden the contributing subpage links.

Remove governance link that goes nowhere.
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 4, 2016

I've emboldened the subsection links and also removed the prominent governance link temporarily until we have content for it.

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Jan 5, 2016

@brson: 👍

Btw, are you planning to land these various PRs separately? Or, now that there are cross-cutting style changes, do you want to land them all together?

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 12, 2016

@aturon At this point, with the style changes that affect everything I'm planning on landing them together.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 12, 2016

@brson brson closed this Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.