New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add npm to friends page #634

merged 1 commit into from Dec 8, 2016


None yet
4 participants

ashleygwilliams commented Dec 8, 2016



This comment has been minimized.

rust-highfive commented Dec 8, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik steveklabnik merged commit ebbda10 into rust-lang:master Dec 8, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress

This comment has been minimized.


steveklabnik commented Dec 8, 2016


@ashleygwilliams ashleygwilliams deleted the ashleygwilliams:add-npm branch Dec 8, 2016


This comment has been minimized.


alexcrichton commented Dec 8, 2016


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment