Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify Captures::len includes non-matching captures #832

wants to merge 1 commit into from


Copy link

@CAD97 CAD97 commented Jan 28, 2022

This caught me out: mentally I map "captured groups" to the successful captures; capture groups that didn't capture anything weren't "captured." I understand why the function returns what it does in retrospect, but hopefully this can help someone else.

Copy link

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the same change to as well?

Copy link

Nevermind, I'll make the change and include it in a rollup.

BurntSushi pushed a commit that referenced this pull request Jul 5, 2022
We do the same for CaptureLocations too.

Closes #832
@BurntSushi BurntSushi closed this in 7d21662 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants