Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAuto-merge approved RFCs #198
Comments
Centril
referenced this issue
Apr 21, 2018
Merged
Human friendly incantations + Auto Closing/Postponing RFCs + More labels #197
This comment has been minimized.
This comment has been minimized.
|
Note that "merge doesn't always mean merge": rust-lang/rust#56138 (comment) |
This comment has been minimized.
This comment has been minimized.
|
@dwijnand Yea, that's why this should only apply to RFCs and not rust-lang/rust PRs ;) We need to post-process the PRs anyways for merge conflicts, other small fixes, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Centril commentedApr 21, 2018
Opening an issue per discussion at #197 (diff).
To save the rfc-pushers some time, it would be nice to auto-merge RFCs that are FFCPed (finished-final-comment-period).
This is a complicated process which involves these steps executed (by a human right now..) in order:
C-tracking-issue,B-RFC-approvedteamthe RFC falls under, apply a labelT-team.T-lang, mentoring instructions come fromT-compiler.titleof the RFC and substituteXXXinThis is a tracking issue for the RFC "XXX"with the title.RFC:(case insensitive). This also applies to similar suffixes.Tracking issue for RFC <number>, <title>where<title>is dependent on step 3.4.0000in the file name of the committed file with<number>.RFC <number>.This procedure has multiple points of failure for a bot. If a failure does happen, the bot should stop immediately and post a comment on the RFC saying "automated merge procedure failed, please merge manually."
Who will implement this? I will (at some point).